From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf clang-format: Prioritize Python.h and expand other categories
Date: Tue, 26 May 2026 22:48:01 +0000 [thread overview]
Message-ID: <20260526224802.1A6711F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260526224241.4016312-1-irogers@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message contradicts the actual patch implementation regarding header sorting priorities.
--
commit 6df1a36d29968fecb941bfb94a7d676143f46552
Author: Ian Rogers <irogers@google.com>
perf clang-format: Prioritize Python.h and expand other categories
This commit updates the .clang-format rules for the perf tools. It
prioritizes Python.h sorting and expands the regex lists for C standard
library and OS specific headers.
> - Prioritize Python.h by sorting it first (Priority 0).
> - Shift other header priorities down to accommodate Python.h.
[Severity: Medium]
Is this description accurate regarding the patch implementation?
The commit message states Python.h is set to Priority 0 and other
priorities are shifted down. However, the patch actually assigns
Priority -1 to Python.h and leaves the other categories at their
original priorities (1 and 2).
Setting the priority to -1 also means Python.h will be sorted before
the C file's main header, which implicitly has Priority 0.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260526224241.4016312-1-irogers@google.com?part=1
prev parent reply other threads:[~2026-05-26 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 21:39 [PATCH v1] perf clang-format: Prioritize Python.h and expand other categories Ian Rogers
2026-05-26 21:46 ` sashiko-bot
2026-05-26 22:42 ` [PATCH v2] " Ian Rogers
2026-05-26 22:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526224802.1A6711F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox