From: David Laight <david.laight.linux@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Yury Norov" <ynorov@nvidia.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Russell King" <linux@armlinux.org.uk>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"James Clark" <james.clark@linaro.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Moritz Fischer" <mdf@kernel.org>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Dennis Dalessandro" <dennis.dalessandro@cornelisnetworks.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
"Dan Williams" <djbw@kernel.org>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Shuai Xue" <xueshuai@linux.alibaba.com>,
"Will Deacon" <will@kernel.org>,
"Jiucheng Xu" <jiucheng.xu@amlogic.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Jing Zhang" <renyu.zj@linux.alibaba.com>,
"Xu Yang" <xu.yang_2@nxp.com>,
"Linu Cherian" <lcherian@marvell.com>,
"Gowthami Thiagarajan" <gthiagarajan@marvell.com>,
"Ji Sheng Teoh" <jisheng.teoh@starfivetech.com>,
"Khuong Dinh" <khuong@os.amperecomputing.com>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Kees Cook" <kees@kernel.org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Aboorva Devarajan" <aboorvad@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Ilkka Koskinen" <ilkka@os.amperecomputing.com>,
"Besar Wicaksono" <bwicaksono@nvidia.com>,
"Ma Ke" <make24@iscas.ac.cn>,
"Chengwen Feng" <fengchengwen@huawei.com>,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-perf-users@vger.kernel.org, linux-acpi@vger.kernel.org,
driver-core@lists.linux.dev, linux-pm@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-fpga@vger.kernel.org,
linux-rdma@vger.kernel.org, nvdimm@lists.linux.dev,
linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-cxl@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 13/16] perf: Use sysfs_emit() for cpumask show callbacks
Date: Fri, 29 May 2026 13:06:19 +0100 [thread overview]
Message-ID: <20260529130619.12f24264@pumpkin> (raw)
In-Reply-To: <7e980b99-1e4e-408b-8ebd-4d28116e7ad5@arm.com>
On Fri, 29 May 2026 12:05:08 +0100
Robin Murphy <robin.murphy@arm.com> wrote:
> On 2026-05-28 7:36 pm, Yury Norov wrote:
> > These callbacks are sysfs show paths.
> >
> > Use sysfs_emit() and cpumask_pr_args() to emit the masks.
> >
> > This prepares for removing cpumap_print_to_pagebuf().
>
> TBH, looking at this diff I think it only shows the value of having a
> helper to abstract the boilerplate...
>
> I'm not sure I agree with the argument of removing something entirely
> just because it may occasionally be misused, but could we at least have
> something like:
>
> #define sysfs_emit_cpumask(buf, mask) \
> sysfs_emit((buf), "%*pbl\n", cpumask_pr_args(mask))
>
> to save the mess in all the many places where the current
> cpumap_print_to_pagebuf() usage _is_ entirely appropriate?
That has the advantage of letting you change how it is done (again)
without having to find all the callers.
-- David
>
> Thansk,
> Robin.
>
> > Signed-off-by: Yury Norov <ynorov@nvidia.com>
> > ---
> > drivers/perf/alibaba_uncore_drw_pmu.c | 2 +-
> > drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +-
> > drivers/perf/arm-cci.c | 2 +-
> > drivers/perf/arm-ccn.c | 2 +-
> > drivers/perf/arm-cmn.c | 2 +-
> > drivers/perf/arm-ni.c | 2 +-
> > drivers/perf/arm_cspmu/arm_cspmu.c | 2 +-
> > drivers/perf/arm_dmc620_pmu.c | 4 ++--
> > drivers/perf/arm_dsu_pmu.c | 2 +-
> > drivers/perf/arm_pmu.c | 2 +-
> > drivers/perf/arm_smmuv3_pmu.c | 2 +-
> > drivers/perf/arm_spe_pmu.c | 2 +-
> > drivers/perf/cxl_pmu.c | 2 +-
> > drivers/perf/dwc_pcie_pmu.c | 2 +-
> > drivers/perf/fsl_imx8_ddr_perf.c | 2 +-
> > drivers/perf/fsl_imx9_ddr_perf.c | 2 +-
> > drivers/perf/fujitsu_uncore_pmu.c | 2 +-
> > drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +-
> > drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +-
> > drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +-
> > drivers/perf/marvell_cn10k_tad_pmu.c | 2 +-
> > drivers/perf/marvell_pem_pmu.c | 2 +-
> > drivers/perf/nvidia_t410_c2c_pmu.c | 2 +-
> > drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +-
> > drivers/perf/qcom_l2_pmu.c | 2 +-
> > drivers/perf/qcom_l3_pmu.c | 2 +-
> > drivers/perf/starfive_starlink_pmu.c | 2 +-
> > drivers/perf/thunderx2_pmu.c | 2 +-
> > drivers/perf/xgene_pmu.c | 2 +-
> > kernel/events/core.c | 2 +-
> > 30 files changed, 31 insertions(+), 31 deletions(-)
> >
> > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> > index ac49d3b2dad6..74786a5dd6a2 100644
> > --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> > @@ -221,7 +221,7 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev,
> > {
> > struct ali_drw_pmu *drw_pmu = to_ali_drw_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(drw_pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(drw_pmu->cpu)));
> > }
> >
> > static struct device_attribute ali_drw_pmu_cpumask_attr =
> > diff --git a/drivers/perf/amlogic/meson_ddr_pmu_core.c b/drivers/perf/amlogic/meson_ddr_pmu_core.c
> > index c1e755c356a3..f614aa3434a5 100644
> > --- a/drivers/perf/amlogic/meson_ddr_pmu_core.c
> > +++ b/drivers/perf/amlogic/meson_ddr_pmu_core.c
> > @@ -191,7 +191,7 @@ static ssize_t meson_ddr_perf_cpumask_show(struct device *dev,
> > {
> > struct ddr_pmu *pmu = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu)));
> > }
> >
> > static struct device_attribute meson_ddr_perf_cpumask_attr =
> > diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c
> > index 1cc3214d6b6d..f0ef0a679e74 100644
> > --- a/drivers/perf/arm-cci.c
> > +++ b/drivers/perf/arm-cci.c
> > @@ -1351,7 +1351,7 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev,
> > struct pmu *pmu = dev_get_drvdata(dev);
> > struct cci_pmu *cci_pmu = to_cci_pmu(pmu);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(cci_pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(cci_pmu->cpu)));
> > }
> >
> > static struct device_attribute pmu_cpumask_attr =
> > diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
> > index 8af3563fdf60..d5dcb4280434 100644
> > --- a/drivers/perf/arm-ccn.c
> > +++ b/drivers/perf/arm-ccn.c
> > @@ -538,7 +538,7 @@ static ssize_t arm_ccn_pmu_cpumask_show(struct device *dev,
> > {
> > struct arm_ccn *ccn = pmu_to_arm_ccn(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(ccn->dt.cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(ccn->dt.cpu)));
> > }
> >
> > static struct device_attribute arm_ccn_pmu_cpumask_attr =
> > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> > index f5305c8fdca4..2187ba763b72 100644
> > --- a/drivers/perf/arm-cmn.c
> > +++ b/drivers/perf/arm-cmn.c
> > @@ -1326,7 +1326,7 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev,
> > {
> > struct arm_cmn *cmn = to_cmn(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(cmn->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(cmn->cpu)));
> > }
> >
> > static struct device_attribute arm_cmn_cpumask_attr =
> > diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
> > index 66858c65215d..03a1c6bf9223 100644
> > --- a/drivers/perf/arm-ni.c
> > +++ b/drivers/perf/arm-ni.c
> > @@ -239,7 +239,7 @@ static ssize_t arm_ni_cpumask_show(struct device *dev,
> > {
> > struct arm_ni *ni = cd_to_ni(pmu_to_cd(dev_get_drvdata(dev)));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(ni->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(ni->cpu)));
> > }
> >
> > static struct device_attribute arm_ni_cpumask_attr =
> > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
> > index 80fb314d5135..e6292021f653 100644
> > --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> > @@ -305,7 +305,7 @@ static ssize_t arm_cspmu_cpumask_show(struct device *dev,
> > default:
> > return 0;
> > }
> > - return cpumap_print_to_pagebuf(true, buf, cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask));
> > }
> >
> > static struct attribute *arm_cspmu_cpumask_attrs[] = {
> > diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c
> > index 4f6b196160f8..467147a05eec 100644
> > --- a/drivers/perf/arm_dmc620_pmu.c
> > +++ b/drivers/perf/arm_dmc620_pmu.c
> > @@ -237,8 +237,8 @@ static ssize_t dmc620_pmu_cpumask_show(struct device *dev,
> > {
> > struct dmc620_pmu *dmc620_pmu = to_dmc620_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf,
> > - cpumask_of(dmc620_pmu->irq->cpu));
> > + return sysfs_emit(buf, "%*pbl\n",
> > + cpumask_pr_args(cpumask_of(dmc620_pmu->irq->cpu)));
> > }
> >
> > static struct device_attribute dmc620_pmu_cpumask_attr =
> > diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
> > index 32b0dd7c693b..bcbd19e075a5 100644
> > --- a/drivers/perf/arm_dsu_pmu.c
> > +++ b/drivers/perf/arm_dsu_pmu.c
> > @@ -157,7 +157,7 @@ static ssize_t dsu_pmu_cpumask_show(struct device *dev,
> > default:
> > return 0;
> > }
> > - return cpumap_print_to_pagebuf(true, buf, cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask));
> > }
> >
> > static struct attribute *dsu_pmu_format_attrs[] = {
> > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> > index 939bcbd433aa..51ab6cc52ca0 100644
> > --- a/drivers/perf/arm_pmu.c
> > +++ b/drivers/perf/arm_pmu.c
> > @@ -570,7 +570,7 @@ static ssize_t cpus_show(struct device *dev,
> > struct device_attribute *attr, char *buf)
> > {
> > struct arm_pmu *armpmu = to_arm_pmu(dev_get_drvdata(dev));
> > - return cpumap_print_to_pagebuf(true, buf, &armpmu->supported_cpus);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&armpmu->supported_cpus));
> > }
> >
> > static DEVICE_ATTR_RO(cpus);
> > diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c
> > index 621f02a7f43b..8ce34e6bb82b 100644
> > --- a/drivers/perf/arm_smmuv3_pmu.c
> > +++ b/drivers/perf/arm_smmuv3_pmu.c
> > @@ -537,7 +537,7 @@ static ssize_t smmu_pmu_cpumask_show(struct device *dev,
> > {
> > struct smmu_pmu *smmu_pmu = to_smmu_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(smmu_pmu->on_cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(smmu_pmu->on_cpu)));
> > }
> >
> > static struct device_attribute smmu_pmu_cpumask_attr =
> > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
> > index dbd0da111639..9f786fd48cdd 100644
> > --- a/drivers/perf/arm_spe_pmu.c
> > +++ b/drivers/perf/arm_spe_pmu.c
> > @@ -343,7 +343,7 @@ static ssize_t cpumask_show(struct device *dev,
> > {
> > struct arm_spe_pmu *spe_pmu = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, &spe_pmu->supported_cpus);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&spe_pmu->supported_cpus));
> > }
> > static DEVICE_ATTR_RO(cpumask);
> >
> > diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c
> > index 68a54d97d2a8..0735eb33f5f3 100644
> > --- a/drivers/perf/cxl_pmu.c
> > +++ b/drivers/perf/cxl_pmu.c
> > @@ -493,7 +493,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > {
> > struct cxl_pmu_info *info = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(info->on_cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(info->on_cpu)));
> > }
> > static DEVICE_ATTR_RO(cpumask);
> >
> > diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c
> > index 5385401fa9cf..291e776d6f6a 100644
> > --- a/drivers/perf/dwc_pcie_pmu.c
> > +++ b/drivers/perf/dwc_pcie_pmu.c
> > @@ -117,7 +117,7 @@ static ssize_t cpumask_show(struct device *dev,
> > {
> > struct dwc_pcie_pmu *pcie_pmu = to_dwc_pcie_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pcie_pmu->on_cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pcie_pmu->on_cpu)));
> > }
> > static DEVICE_ATTR_RO(cpumask);
> >
> > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> > index bcdf5575d71c..3760ebe02674 100644
> > --- a/drivers/perf/fsl_imx8_ddr_perf.c
> > +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> > @@ -237,7 +237,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev,
> > {
> > struct ddr_pmu *pmu = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu)));
> > }
> >
> > static struct device_attribute ddr_perf_cpumask_attr =
> > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> > index 7050b48c0467..6fee5eb5087a 100644
> > --- a/drivers/perf/fsl_imx9_ddr_perf.c
> > +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> > @@ -159,7 +159,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev,
> > {
> > struct ddr_pmu *pmu = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu)));
> > }
> >
> > static struct device_attribute ddr_perf_cpumask_attr =
> > diff --git a/drivers/perf/fujitsu_uncore_pmu.c b/drivers/perf/fujitsu_uncore_pmu.c
> > index c3c6f56474ad..a07877632d53 100644
> > --- a/drivers/perf/fujitsu_uncore_pmu.c
> > +++ b/drivers/perf/fujitsu_uncore_pmu.c
> > @@ -374,7 +374,7 @@ static ssize_t cpumask_show(struct device *dev,
> > {
> > struct uncore_pmu *uncorepmu = to_uncore_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(uncorepmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(uncorepmu->cpu)));
> > }
> > static DEVICE_ATTR_RO(cpumask);
> >
> > diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> > index c5394d007b61..0f55d871c67e 100644
> > --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c
> > +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> > @@ -121,7 +121,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, c
> > {
> > struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pcie_pmu->on_cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pcie_pmu->on_cpu)));
> > }
> > static DEVICE_ATTR_RO(cpumask);
> >
> > diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> > index de71dcf11653..0ff2fdf4b3e2 100644
> > --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c
> > +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> > @@ -56,7 +56,7 @@ static ssize_t hisi_associated_cpus_sysfs_show(struct device *dev,
> > {
> > struct hisi_pmu *hisi_pmu = to_hisi_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, &hisi_pmu->associated_cpus);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&hisi_pmu->associated_cpus));
> > }
> > static DEVICE_ATTR(associated_cpus, 0444, hisi_associated_cpus_sysfs_show, NULL);
> >
> > diff --git a/drivers/perf/marvell_cn10k_ddr_pmu.c b/drivers/perf/marvell_cn10k_ddr_pmu.c
> > index 72ac17efd846..8681e8715cb3 100644
> > --- a/drivers/perf/marvell_cn10k_ddr_pmu.c
> > +++ b/drivers/perf/marvell_cn10k_ddr_pmu.c
> > @@ -364,7 +364,7 @@ static ssize_t cn10k_ddr_perf_cpumask_show(struct device *dev,
> > {
> > struct cn10k_ddr_pmu *pmu = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu)));
> > }
> >
> > static struct device_attribute cn10k_ddr_perf_cpumask_attr =
> > diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c
> > index 51ccb0befa05..54909d0031b7 100644
> > --- a/drivers/perf/marvell_cn10k_tad_pmu.c
> > +++ b/drivers/perf/marvell_cn10k_tad_pmu.c
> > @@ -258,7 +258,7 @@ static ssize_t tad_pmu_cpumask_show(struct device *dev,
> > {
> > struct tad_pmu *tad_pmu = to_tad_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(tad_pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(tad_pmu->cpu)));
> > }
> >
> > static DEVICE_ATTR(cpumask, 0444, tad_pmu_cpumask_show, NULL);
> > diff --git a/drivers/perf/marvell_pem_pmu.c b/drivers/perf/marvell_pem_pmu.c
> > index 29fbcd1848e4..cf1d8cdb1318 100644
> > --- a/drivers/perf/marvell_pem_pmu.c
> > +++ b/drivers/perf/marvell_pem_pmu.c
> > @@ -164,7 +164,7 @@ static ssize_t pem_perf_cpumask_show(struct device *dev,
> > {
> > struct pem_pmu *pmu = dev_get_drvdata(dev);
> >
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu)));
> > }
> >
> > static struct device_attribute pem_perf_cpumask_attr =
> > diff --git a/drivers/perf/nvidia_t410_c2c_pmu.c b/drivers/perf/nvidia_t410_c2c_pmu.c
> > index 411987153ff3..bff875f4f625 100644
> > --- a/drivers/perf/nvidia_t410_c2c_pmu.c
> > +++ b/drivers/perf/nvidia_t410_c2c_pmu.c
> > @@ -658,7 +658,7 @@ static ssize_t nv_c2c_pmu_cpumask_show(struct device *dev,
> > default:
> > return 0;
> > }
> > - return cpumap_print_to_pagebuf(true, buf, cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask));
> > }
> >
> > #define NV_C2C_PMU_CPUMASK_ATTR(_name, _config) \
> > diff --git a/drivers/perf/nvidia_t410_cmem_latency_pmu.c b/drivers/perf/nvidia_t410_cmem_latency_pmu.c
> > index acb8f5571522..6c8e41598ec1 100644
> > --- a/drivers/perf/nvidia_t410_cmem_latency_pmu.c
> > +++ b/drivers/perf/nvidia_t410_cmem_latency_pmu.c
> > @@ -501,7 +501,7 @@ static ssize_t cmem_lat_pmu_cpumask_show(struct device *dev,
> > default:
> > return 0;
> > }
> > - return cpumap_print_to_pagebuf(true, buf, cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask));
> > }
> >
> > #define NV_PMU_CPUMASK_ATTR(_name, _config) \
> > diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
> > index ea8c85729937..c0c522b10b72 100644
> > --- a/drivers/perf/qcom_l2_pmu.c
> > +++ b/drivers/perf/qcom_l2_pmu.c
> > @@ -638,7 +638,7 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev,
> > {
> > struct l2cache_pmu *l2cache_pmu = to_l2cache_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, &l2cache_pmu->cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&l2cache_pmu->cpumask));
> > }
> >
> > static struct device_attribute l2_cache_pmu_cpumask_attr =
> > diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c
> > index 66e6cabd6fff..c8d259dd1f80 100644
> > --- a/drivers/perf/qcom_l3_pmu.c
> > +++ b/drivers/perf/qcom_l3_pmu.c
> > @@ -663,7 +663,7 @@ static ssize_t cpumask_show(struct device *dev,
> > {
> > struct l3cache_pmu *l3pmu = to_l3cache_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, &l3pmu->cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&l3pmu->cpumask));
> > }
> >
> > static DEVICE_ATTR_RO(cpumask);
> > diff --git a/drivers/perf/starfive_starlink_pmu.c b/drivers/perf/starfive_starlink_pmu.c
> > index 964897c2baa9..222a0a34e211 100644
> > --- a/drivers/perf/starfive_starlink_pmu.c
> > +++ b/drivers/perf/starfive_starlink_pmu.c
> > @@ -131,7 +131,7 @@ cpumask_show(struct device *dev, struct device_attribute *attr, char *buf)
> > {
> > struct starlink_pmu *starlink_pmu = to_starlink_pmu(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, &starlink_pmu->cpumask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&starlink_pmu->cpumask));
> > }
> >
> > static DEVICE_ATTR_RO(cpumask);
> > diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c
> > index 6ed4707bd6bb..a69c02d2d874 100644
> > --- a/drivers/perf/thunderx2_pmu.c
> > +++ b/drivers/perf/thunderx2_pmu.c
> > @@ -254,7 +254,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > struct tx2_uncore_pmu *tx2_pmu;
> >
> > tx2_pmu = pmu_to_tx2_pmu(dev_get_drvdata(dev));
> > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(tx2_pmu->cpu));
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(tx2_pmu->cpu)));
> > }
> > static DEVICE_ATTR_RO(cpumask);
> >
> > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> > index 33b5497bdc06..e9e4871db08d 100644
> > --- a/drivers/perf/xgene_pmu.c
> > +++ b/drivers/perf/xgene_pmu.c
> > @@ -595,7 +595,7 @@ static ssize_t cpumask_show(struct device *dev,
> > {
> > struct xgene_pmu_dev *pmu_dev = to_pmu_dev(dev_get_drvdata(dev));
> >
> > - return cpumap_print_to_pagebuf(true, buf, &pmu_dev->parent->cpu);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&pmu_dev->parent->cpu));
> > }
> >
> > static DEVICE_ATTR_RO(cpumask);
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 7935d5663944..61689d348abd 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -12657,7 +12657,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > struct cpumask *mask = perf_scope_cpumask(pmu->scope);
> >
> > if (mask)
> > - return cpumap_print_to_pagebuf(true, buf, mask);
> > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(mask));
> > return 0;
> > }
> >
>
>
next prev parent reply other threads:[~2026-05-29 12:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 18:36 [PATCH 00/16] lib/cpumask: get rid of cpumap_print_to_pagebuf() Yury Norov
2026-05-28 18:36 ` [PATCH 01/16] psci: simplify hotplug_tests() Yury Norov
2026-05-29 12:24 ` Robin Murphy
2026-05-28 18:36 ` [PATCH 02/16] arm: Use sysfs_emit() for cpumask show callbacks Yury Norov
2026-05-28 18:36 ` [PATCH 03/16] powerpc: " Yury Norov
2026-05-28 18:36 ` [PATCH 04/16] x86/events: " Yury Norov
2026-05-28 18:36 ` [PATCH 05/16] ACPI: pad: Use sysfs_emit() for idlecpus show Yury Norov
2026-05-28 18:36 ` [PATCH 06/16] cpu: Use sysfs_emit() for cpumask show callback Yury Norov
2026-05-28 18:36 ` [PATCH 07/16] devfreq: Use sysfs_emit() for cpumask show callbacks Yury Norov
2026-05-28 18:36 ` [PATCH 08/16] fpga: dfl-fme-perf: Use sysfs_emit() for cpumask show Yury Norov
2026-05-28 18:36 ` [PATCH 09/16] hwtracing: hisi_ptt: " Yury Norov
2026-05-28 18:36 ` [PATCH 10/16] RDMA/hfi1: Use sysfs_emit() for cpumask show helper Yury Norov
2026-05-28 18:36 ` [PATCH 11/16] nvdimm: Use sysfs_emit() for cpumask show callback Yury Norov
2026-05-28 18:36 ` [PATCH 12/16] PCI/sysfs: Use sysfs_emit() for cpumask show callbacks Yury Norov
2026-05-28 18:36 ` [PATCH 13/16] perf: " Yury Norov
2026-05-29 11:05 ` Robin Murphy
2026-05-29 12:06 ` David Laight [this message]
2026-05-28 18:36 ` [PATCH 14/16] powercap: intel_rapl: Use sysfs_emit() for cpumask show Yury Norov
2026-05-28 18:36 ` [PATCH 15/16] thermal: intel: Use sysfs_emit() for powerclamp cpumask Yury Norov
2026-05-28 18:36 ` [PATCH 16/16] lib/bitmap-str: get rid of cpumap_print_to_pagebuf() Yury Norov
2026-05-28 19:18 ` [PATCH 00/16] lib/cpumask: " Andrew Morton
2026-05-28 19:26 ` Yury Norov
2026-05-28 19:29 ` Andrew Morton
2026-05-28 19:32 ` Yury Norov
2026-05-28 19:44 ` Ian Rogers
2026-05-28 19:52 ` Yury Norov
2026-05-28 20:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529130619.12f24264@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=aboorvad@linux.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=bwicaksono@nvidia.com \
--cc=chleroy@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dakr@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=djbw@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=fengchengwen@huawei.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gthiagarajan@marvell.com \
--cc=heiko@sntech.de \
--cc=hpa@zytor.com \
--cc=ilkka@os.amperecomputing.com \
--cc=imx@lists.linux.dev \
--cc=ira.weiny@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=jgg@ziepe.ca \
--cc=jic23@kernel.org \
--cc=jisheng.teoh@starfivetech.com \
--cc=jiucheng.xu@amlogic.com \
--cc=jolsa@kernel.org \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=khuong@os.amperecomputing.com \
--cc=kyungmin.park@samsung.com \
--cc=lcherian@marvell.com \
--cc=lenb@kernel.org \
--cc=leon@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=lukasz.luba@arm.com \
--cc=maddy@linux.ibm.com \
--cc=make24@iscas.ac.cn \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mdf@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=myungjoo.ham@samsung.com \
--cc=namhyung@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=npiggin@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=ritesh.list@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=trix@redhat.com \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
--cc=xu.yang_2@nxp.com \
--cc=xueshuai@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=yilun.xu@intel.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox