Re: [PATCH 1/3] net: Remove support for AIO on sockets

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `outlen` field in `struct af_alg_async_req` is unused.
- [Low] Obsolete error handling and comments for `-EIOCBQUEUED` in `algif_aead.c` and `algif_skcipher.c`.
--

commit 64f74b492ae582ab9df137534f38a66893730e73
Author: Demi Marie Obenour <demiobenour@gmail.com>

net: Remove support for AIO on sockets

This commit removes support for asynchronous I/O on sockets, as the only
user (AF_ALG) is deprecated. This reduces the size of struct msghdr by
removing msg_iocb and makes operations strictly synchronous.

> diff --git a/crypto/algif_aead.c b/crypto/algif_aead.c
> index c6c2ce21895dd..60f06597cb0b1 100644
> --- a/crypto/algif_aead.c
> +++ b/crypto/algif_aead.c
[ ... ]
> @@ -197,37 +197,14 @@ static int _aead_recvmsg(struct socket *sock, struct msghdr *msg,
>  	aead_request_set_ad(&areq->cra_u.aead_req, ctx->aead_assoclen);
>  	aead_request_set_tfm(&areq->cra_u.aead_req, tfm);
>  
> -	if (msg->msg_iocb && !is_sync_kiocb(msg->msg_iocb)) {
[ ... ]
> -		err = ctx->enc ? crypto_aead_encrypt(&areq->cra_u.aead_req) :
> -				 crypto_aead_decrypt(&areq->cra_u.aead_req);
> -
> -		/* AIO operation in progress */
> -		if (err == -EINPROGRESS)
> -			return -EIOCBQUEUED;

[Severity: Low]
Since operations are now strictly synchronous and no longer return
-EIOCBQUEUED here, do the callers like aead_recvmsg() and skcipher_recvmsg()
still need to check for -EIOCBQUEUED? It seems the error handling and
comments explaining AIO request limits in the outer loops might now be
leftover dead code.

> -
> -		sock_put(sk);
> -	} else {
> -		/* Synchronous operation */
[ ... ]
> diff --git a/include/crypto/if_alg.h b/include/crypto/if_alg.h
> index 0cc8fa749f68d..62867daca47d7 100644
> --- a/include/crypto/if_alg.h
> +++ b/include/crypto/if_alg.h
> @@ -80,7 +80,6 @@ struct af_alg_rsgl {
>  
>  /**
>   * struct af_alg_async_req - definition of crypto request
> - * @iocb:		IOCB for AIO operations
>   * @sk:			Socket the request is associated with
>   * @first_rsgl:		First RX SG
>   * @last_rsgl:		Pointer to last RX SG
> @@ -92,7 +91,6 @@ struct af_alg_rsgl {
>   * @cra_u:		Cipher request
>   */
>  struct af_alg_async_req {
> -	struct kiocb *iocb;
>  	struct sock *sk;

[Severity: Low]
Does this struct still need the outlen field?

The patch removes the af_alg_async_cb callback and the areq->outlen
assignments that were used during AIO operations, so it looks like outlen
is now completely unused and could be removed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260523-af-alg-harden-v1-0-c76755c3a5c5@gmail.com?part=1