From: sashiko-bot@kernel.org
To: "Sandipan Das" <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf vendor events amd: Update Zen 5 core events
Date: Mon, 01 Jun 2026 16:21:26 +0000 [thread overview]
Message-ID: <20260601162126.D5BE91F00893@smtp.kernel.org> (raw)
In-Reply-To: <f16d1391366762dee0d49f00697f5e6ea913e2c1.1780330378.git.sandipan.das@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect description for the newly added `fp_ops_retired_by_type.scalar_logical` PMU event.
--
commit ec579a038d59c44007350888149b4dd94c5079db
Author: Sandipan Das <sandipan.das@amd.com>
perf vendor events amd: Update Zen 5 core events
This commit updates the definitions for Zen 5 core events by adding missing
unit masks and fixing descriptions for several PMCx events.
> diff --git a/tools/perf/pmu-events/arch/x86/amdzen5/floating-point.json b/tools/perf/pmu-events/arch/x86/amdzen5/floating-point.json
> index 9204bfb1d69e0..39bd720f95414 100644
> --- a/tools/perf/pmu-events/arch/x86/amdzen5/floating-point.json
> +++ b/tools/perf/pmu-events/arch/x86/amdzen5/floating-point.json
[ ... ]
> @@ -179,6 +179,30 @@
> "BriefDescription": "Retired scalar floating-point blend ops.",
> "UMask": "0x09"
> },
> + {
> + "EventName": "fp_ops_retired_by_type.scalar_mov",
> + "EventCode": "0x0a",
> + "BriefDescription": "Retired scalar floating-point MOV ops.",
> + "UMask": "0x0a"
> + },
> + {
> + "EventName": "fp_ops_retired_by_type.scalar_shuffle",
> + "EventCode": "0x0a",
> + "BriefDescription": "Retired scalar floating-point shuffle ops (may include instructions not necessarily thought of as including shuffles e.g. horizontal add, dot product, and certain MOV instructions).",
> + "UMask": "0x0b"
> + },
> + {
> + "EventName": "fp_ops_retired_by_type.scalar_bfloat",
> + "EventCode": "0x0a",
> + "BriefDescription": "Retired scalar floating-point bfloat ops.",
> + "UMask": "0x0c"
> + },
> + {
> + "EventName": "fp_ops_retired_by_type.scalar_logical",
> + "EventCode": "0x0a",
> + "BriefDescription": "Retired scalar floating-point move ops.",
[Severity: Low]
This isn't a bug, but there is a typo in the description for the
scalar_logical event. It currently reads "move ops", duplicating the
description from the scalar_mov event. Should this be "logical ops"?
A subsequent patch in the series (commit "perf vendor events amd: Update Zen
6 core events") fixes this identical typo for Zen 6 architectures, but it
appears to remain unaddressed here for Zen 5.
> + "UMask": "0x0d"
> + },
--
Sashiko AI review · https://sashiko.dev/#/patchset/f16d1391366762dee0d49f00697f5e6ea913e2c1.1780330378.git.sandipan.das@amd.com?part=1
prev parent reply other threads:[~2026-06-01 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 16:15 [PATCH 1/2] perf vendor events amd: Update Zen 5 core events Sandipan Das
2026-06-01 16:15 ` [PATCH 2/2] perf vendor events amd: Update Zen 6 " Sandipan Das
2026-06-01 16:21 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601162126.D5BE91F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sandipan.das@amd.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox