Re: [PATCH v2 08/18] perf test cs-etm: Replace memcpy test with raw dump stress test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The explicit error handling block for `perf report` is fully unreachable due to `set -e`, making the intended diagnostic failure messages dead code.
--

commit 8eeed98667ec7c0548c0c55cf60670252a0dad1d
Author: James Clark <james.clark@linaro.org>

perf test cs-etm: Replace memcpy test with raw dump stress test

This replaces the coresight memcpy test with a raw dump stress test that
verifies the generation of a specific amount of raw output without requiring
a custom binary. It also introduces coverage for exit snapshot mode.

> diff --git a/tools/perf/tests/shell/coresight/raw_dump_stress.sh b/tools/perf/tests/shell/coresight/raw_dump_stress.sh
> new file mode 100755
> index 0000000000000..eb5a5e5e1be62
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight/raw_dump_stress.sh
> @@ -0,0 +1,54 @@
> +#!/bin/bash -e
> +# Coresight raw dump stress (exclusive)

[ ... ]

> +echo "Dumping raw trace..."
> +perf report --dump-raw-trace -i "$tmpdir/data" 2>/dev/null > "$tmpdir/rawdump"
> +err=$?
> +
> +if [ $err -ne 0 ]; then
> +	echo "FAIL: perf report failed with error code $err"
> +	cleanup
> +	exit 1
> +fi

[Severity: Medium]
Will this error handling block ever be reached if perf report fails?

Since the script starts with #!/bin/bash -e, a non-zero exit code from a
standalone command like perf report causes the shell to exit immediately and
trigger the trap_cleanup EXIT trap.

Could this prevent the err=$? assignment from occurring, leaving the specific
diagnostic message unprinted?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-james-cs-context-tracking-fix-v2-0-85b5ce6f55c6@linaro.org?part=8