Re: [PATCH 10/10] perf hisi-ptt: Add decoder version compatibility

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The code silently accepts unknown future decoder versions without warning the user, contradicting the commit message.
--

commit 81956f61abf20a5e88b7e9d82765dace1fbc899f
Author: Sizhe Liu <liusizhe5@huawei.com>

perf hisi-ptt: Add decoder version compatibility

This commit introduces a version field to the hisi_ptt auxtrace info record
to distinguish between legacy and detailed packet parsing formats. It updates
the recording and decoding logic to process the data accurately based on the
detected version.

> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index e321f393601b8..4f52cfb4e1903 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
[ ... ]
> @@ -159,10 +166,13 @@ int hisi_ptt_process_auxtrace_info(union perf_event *event,
>  {
[ ... ]
>  	ptt->machine = &session->machines.host; /* No kvm support */
>  	ptt->auxtrace_type = auxtrace_info->type;
>  	ptt->pmu_type = auxtrace_info->priv[0];
> -
> +	ptt->version = priv_size >= HISI_PTT_AUXTRACE_PRIV_SIZE_V2 ?
> +		       (u32)auxtrace_info->priv[1] : HISI_PTT_DECODER_V1;

[Severity: Medium]
The commit message explicitly states: "If version is unknown (future), warn
and decode auxtrace as v2."

Does hisi_ptt_process_auxtrace_info() implement this promised warning? 

It appears to silently assign the future version directly from
auxtrace_info->priv[1] without bounds checking or notifying the user. Could a
warning be added here to match the stated design intent and prevent potential
compatibility issues from being masked?

>  	ptt->auxtrace.process_event = hisi_ptt_process_event;
>  	ptt->auxtrace.process_auxtrace_event = hisi_ptt_process_auxtrace_event;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604075005.2219785-1-liusizhe5@huawei.com?part=10