From: sashiko-bot@kernel.org
To: "Chun-Tse Shao" <ctshao@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 6/6] perf vendor events intel: Update tigerlake events from 1.18 to 1.19
Date: Tue, 09 Jun 2026 21:56:27 +0000 [thread overview]
Message-ID: <20260609215627.DA11B1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260609215046.2391903-7-ctshao@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete patch: The commit updates the Tigerlake event version in mapfile.csv but fails to include the actual updated JSON event files.
--
commit 827bd8b5ad34fdfc9cb54712c5bfc0e4b556fa4f
Author: Chun-Tse Shao <ctshao@google.com>
perf vendor events intel: Update tigerlake events from 1.18 to 1.19
This commit updates the tigerlake event version string in mapfile.csv from
1.18 to 1.19 to track the latest Intel perfmon events.
> diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv
> index 6af3cee12c8a6..a7f8706698272 100644
> --- a/tools/perf/pmu-events/arch/x86/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv
[ ... ]
> @@ -35,7 +35,7 @@ GenuineIntel-6-(37|4A|4C|4D|5A),v15,silvermont,core
> GenuineIntel-6-(4E|5E|8E|9E|A5|A6),v59,skylake,core
> GenuineIntel-6-55-[01234],v1.37,skylakex,core
> GenuineIntel-6-86,v1.23,snowridgex,core
> -GenuineIntel-6-8[CD],v1.18,tigerlake,core
> +GenuineIntel-6-8[CD],v1.19,tigerlake,core
[Severity: Medium]
Are the corresponding JSON files for the tigerlake events missing from this
commit?
The patch updates the version string to v1.19 here in mapfile.csv, but it
doesn't include the actual updated JSON event files in the
tools/perf/pmu-events/arch/x86/tigerlake/ directory.
Because jevents.py parses the local JSON files to generate the C event
tables, won't perf continue to be compiled with the outdated v1.18 events
while falsely reporting v1.19?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260609215046.2391903-1-ctshao@google.com?part=6
prev parent reply other threads:[~2026-06-09 21:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 21:50 [PATCH v1 0/6] perf vendor events intel: update Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 1/6] perf vendor events intel: Update arrowlake events from 1.17 to 1.19 Chun-Tse Shao
2026-06-09 22:01 ` sashiko-bot
2026-06-09 21:50 ` [PATCH v1 2/6] perf vendor events intel: Update emeraldrapids events from 1.23 to 1.24 Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 3/6] perf vendor events intel: Update graniterapids events from 1.18 to 1.19 Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 4/6] perf vendor events intel: Update lunarlake events from 1.22 to 1.25 Chun-Tse Shao
2026-06-09 22:02 ` sashiko-bot
2026-06-09 22:58 ` Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 5/6] perf vendor events intel: Update pantherlake events from 1.05 to 1.06 Chun-Tse Shao
2026-06-09 21:50 ` [PATCH v1 6/6] perf vendor events intel: Update tigerlake events from 1.18 to 1.19 Chun-Tse Shao
2026-06-09 21:56 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609215627.DA11B1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ctshao@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox