From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2642EE611; Tue, 16 Jun 2026 01:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781572138; cv=none; b=YdhJT6pukBk4oHFfZt/vDn48Xe/Kh4TZ5dK1UkW8O1YJqrPFxsKOK/M/5kxVrHISesp44KT10JY76wM5TJWw60FlkSUywaZzNL5UCr29xidPbEMeaxwZHFYZO+5DDMnUnHH0obh5jK3325nT5jD0wKGJLuaoFH+93uEE+TfZ2Ng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781572138; c=relaxed/simple; bh=/ouZAdwPNodkqdYcbLkgddbPDqEhLnZ+uZcM97iV06I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RR70GqpEP6wXdcVcpBxUafBkcSbtKSEpq6j6pxZ7hAi8416tFrs4TdtsHgNUAxuk4xZhMO7nGINM31PK4H6BfbgDvznSwLQgW8aAakbakuOShcxoOz61QcPTAW6ant1WQTCm9BkP1dni+vOCfxh+dpJ/8tks1hxsIvsO/ut6dJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HxHd1ivv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HxHd1ivv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9150D1F000E9; Tue, 16 Jun 2026 01:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781572137; bh=go+3OAOQAlKkBE7/7hRA2XivK9iT+vmvDtATOYjf8XQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HxHd1ivvj9/UWhQwkbSz6REFl99rZvQKG0D7tYIgn7thwXoUDDjI8IP96C6WjOxqN 8OTiElq8JYW6pYs9YD+gGUo0WLiJyZLiub9I6sDEE7VsDPG9fcce93cdamvUw344Rs ECvbvZL/dLc4W50kCwlXTaNtYbsw0QJnNHiAfWLEX8GyRQSBdlJcOwDTtn8M9Ukcv/ 6474b0zIlIbYIIWhO+ncRRjlUFX7xITAinLHrQpD7I7s7+nXivMmavQd2QVDKfJUvB RwsPmidhYYqzd3qBQ+isn0JPef6AnDqgA6FwSWQ6aejJugiP/vFRdCYQElwiYcBv8s lvr3lKpHauIPw== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , sashiko-bot , James Clark , Leo Yan , Claude Subject: [PATCH 4/9] perf cs-etm: Require full global header in auxtrace_info size check Date: Mon, 15 Jun 2026 22:08:29 -0300 Message-ID: <20260616010834.37618-5-acme@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616010834.37618-1-acme@kernel.org> References: <20260616010834.37618-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo cs_etm__process_auxtrace_info() checks that header.size covers event_header_size + INFO_HEADER_SIZE (16 bytes total), but then accesses ptr[CS_PMU_TYPE_CPUS] at offset 24 from the start of the event. A crafted 16-byte auxtrace_info event passes the size check but reads out-of-bounds. Include CS_ETM_HEADER_SIZE in the minimum size check so that the global header entries (version, pmu_type_cpus, snapshot) are guaranteed to fit within the event. Fixes: 55c1de9973d66516 ("perf cs-etm: Print auxtrace info even if OpenCSD isn't linked") Reported-by: sashiko-bot Cc: Adrian Hunter Cc: James Clark Cc: Leo Yan Assisted-by: Claude Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm-base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/cs-etm-base.c b/tools/perf/util/cs-etm-base.c index 4abe416e3febd2cc..aebef71d3a0a1d7b 100644 --- a/tools/perf/util/cs-etm-base.c +++ b/tools/perf/util/cs-etm-base.c @@ -170,7 +170,9 @@ int cs_etm__process_auxtrace_info(union perf_event *event, u64 *ptr = NULL; u64 hdr_version; - if (auxtrace_info->header.size < (event_header_size + INFO_HEADER_SIZE)) + /* Ensure priv[] is large enough for the global header entries */ + if (auxtrace_info->header.size < (event_header_size + INFO_HEADER_SIZE + + CS_ETM_HEADER_SIZE)) return -EINVAL; /* First the global part */ -- 2.54.0