Re: [PATCH v1 11/13] perf python: Zero initialize perf_data in pyrf_data__init

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing explicit inclusion of POSIX standard header `<string.h>` for newly added `memset`.
--

commit 84d9f7832c422ee6951987ed0cdd0d5717fcc7d2
Author: Ian Rogers <irogers@google.com>

perf python: Zero initialize perf_data in pyrf_data__init

This commit replaces clearing the path with memset to zero out the entire
perf_data struct in pyrf_data__init.

> diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
> index e277c89b83477..03b4e88091074 100644
> --- a/tools/perf/util/python.c
> +++ b/tools/perf/util/python.c
> @@ -3607,7 +3607,7 @@ static int pyrf_data__init(struct pyrf_data *pdata, PyObject *args, PyObject *kw
>  	if (pdata->data.open)
>  		perf_data__close(&pdata->data);
>  	free((char *)pdata->data.path);
> -	pdata->data.path = NULL;
> +	memset(&pdata->data, 0, sizeof(pdata->data));

[Severity: Medium]
Will this cause a build failure on musl libc systems? It looks like
memset() is added here but <string.h> is not explicitly included in
tools/perf/util/python.c.

Musl libc enforces strict POSIX namespace separation and does not implicitly
include headers. Could we add an explicit #include <string.h> at the top
of the file to ensure the build succeeds in environments using musl?

>  
>  	if (fd != -1) {
>  		struct stat st;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623053515.2677888-1-irogers@google.com?part=11