Re: [PATCH v4 RESEND 4/7] riscv: stacktrace: introduce stack-bound tracking helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unconditional reference to conditionally defined irq_stack_ptr causes a link-time error when CONFIG_IRQ_STACKS is disabled.
--

commit 64aa629bbd032157beeb94e2add8faf14c975e32
Author: Wang Han <wanghan@linux.alibaba.com>

riscv: stacktrace: introduce stack-bound tracking helpers

This commit introduces building blocks for a reliable stack unwinder 
in RISC-V. It adds stack-bound tracking helpers such as stack_info 
and unwind_state, along with accessors for IRQ, task, and overflow stacks.

> diff --git a/arch/riscv/include/asm/stacktrace.h b/arch/riscv/include/asm/stacktrace.h
> index b1495a7e06ce6..bc87c49403798 100644
> --- a/arch/riscv/include/asm/stacktrace.h
> +++ b/arch/riscv/include/asm/stacktrace.h

[ ... ]

> @@ -16,14 +21,70 @@ extern void notrace walk_stackframe(struct task_struct *task, struct pt_regs *re
>  extern void dump_backtrace(struct pt_regs *regs, struct task_struct *task,
>  			   const char *loglvl);
>  
> -static inline bool on_thread_stack(void)
> +/*
> + * IRQ stack accessors
> + */
> +static inline struct stack_info stackinfo_get_irq(void)
> +{
> +	unsigned long low = (unsigned long)raw_cpu_read(irq_stack_ptr);

[Severity: Low]
Will this cause a link error when CONFIG_IRQ_STACKS is disabled? 

Looking at arch/riscv/kernel/irq.c, irq_stack_ptr is defined inside an 
#ifdef CONFIG_IRQ_STACKS block. Since stackinfo_get_irq() unconditionally
references it here, it seems this might result in an undefined reference
to irq_stack_ptr during linking. 

Should this accessor be conditionally compiled, or should it provide a
fallback when CONFIG_IRQ_STACKS is not set?

> +	unsigned long high = low + IRQ_STACK_SIZE;
> +
> +	return (struct stack_info) {
> +		.low = low,
> +		.high = high,
> +	};
> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629072713.3273743-1-wanghan@linux.alibaba.com?part=4