From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F1238F95A for ; Wed, 1 Jul 2026 05:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782884903; cv=none; b=L4/lTuM7ZsvzVU4RZqxKW7LI43DucLFdxPsHj9sBoiUBmv4QKKj9AEBhta9Sd31ocyy5WQauWx9lXxVhTdNPqXV75WRyVLPJiT3oOox47IGCB1VjGFVcIPMId9wo1wMB3OvLwl2vzYBw9qDsnkoD0e0XkYxJFbqguONW/Ewl9UE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782884903; c=relaxed/simple; bh=yA1c+0JF9UOhV/Xl3MBhcGiz3Vb5PDYxSqgvBiOfjW4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LhNc9Oa3bR8VpDiqfZg5gdbZcEXhcGoyqehsfUZRccBQ5S+C01SPSFeVTWzTMrZcBSoCfERbBy/ohk2NeVUQ0mSgZzeY1oM/zuuU1P1vYpzR2Uz5UGLhyxQWCABgXCK4q0E/+cOmb/jTJLSsi/t45aU9xA/jAQjxEgQ+S6SsjOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L+AMZa5e; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M7oga2xk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L+AMZa5e"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M7oga2xk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782884901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BK91mNMyJzJGSST7TtRI84EslAmBYoPdq+3G8AAlgvw=; b=L+AMZa5e4nrHUflVUIUXnHxSegkE9H6EVxuoiYIxUi6CLxGRALIK1SRz85nOUSxZiBNgdW PQPZuHJcBvEyojHEH/NsCxL8oLx5AXtmmGCsX6Rxh0UvCCiw3TavM550G2o1nnjBYde1fM jiKvqkmjtQz4BAw66ht/cPhOudkpILY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-qmYR5A0YPkijcnpYKLqnTg-1; Wed, 01 Jul 2026 01:48:17 -0400 X-MC-Unique: qmYR5A0YPkijcnpYKLqnTg-1 X-Mimecast-MFC-AGG-ID: qmYR5A0YPkijcnpYKLqnTg_1782884897 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4924725bec9so1985935e9.1 for ; Tue, 30 Jun 2026 22:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782884896; x=1783489696; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BK91mNMyJzJGSST7TtRI84EslAmBYoPdq+3G8AAlgvw=; b=M7oga2xkwDPlD+fbI0wh0Eib2LUJJfW8xN0dA29ZuTv6OzW5ZcfNAkY1sJ1zdQ7lnD m0xLIsOrGoVEXf5rugGTT3S30LJrjLk2VmT94vQgF43kqtY1ks8XR7lrQIFgiLnNG7xa gOWn7Gm0d5LthJcwtc5hnvnYRyYNxoJ/401Hn+5xhwHzjWMVAZxwk/9Gq3ZbzJWvnxi9 gySLsgZIUeWOi98s9UiEiynMJlCzOYewDa4uk6cohqRTL0ZrHK76TzVdKHvQRO4r9fzq kciF/3cgdKjS9ucSsdszMHOHTDtRwWI0CZwze8nHKTBFr7m5lYfGesDoY/zmYJMnLkNS Cfhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782884896; x=1783489696; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BK91mNMyJzJGSST7TtRI84EslAmBYoPdq+3G8AAlgvw=; b=h22kCi4+BPLC0rXf1rJMXpOnM4gDhpH1ChGSi4CQ9STc/Yqm7uPSqNC044gyUZTh+H azDQbMnnSHIRXnsBojK1atHYJSVfhatnF/rrQgrUVYf6dU3zPcUpBxjDOgkKpvtLeumG gRamTTIGmkXMG8ubcQXo+GFaE7KYaFd4adiQU2O5Oqk3ZYnCjOtA7uRhIXIRMjXbiAsv LTLD9RMTUGQeKdrziCWKR4d/KHRbDJBeu5+JrOuYFX8f+4zFRy1rZZQzzlyEDkcZPqwQ QId8am71Z3jza/X9LgkNX2GAIYK8Ln2wUk4YnQrj7nQwsXVNSGUqF4EgK3mj+gYve4vL cvsQ== X-Forwarded-Encrypted: i=1; AFNElJ+KY5WgMJxK5xvrHgKgfqHGxsTeWOzqq2/NCjLvumv3Nc74wxGPhMLh3lKSNY2ZkG34iB8DN+DoVpcDIAqlo3g5@vger.kernel.org X-Gm-Message-State: AOJu0YwIhbflM4OQ8MqesyeK6S602ctGGFjT5+SgdHQXRL4oJVJQv+oX eklD3DBuRC4/qtBNi50d/t4R12DhYz47zPZ34Ae8TbttEgORAi+OZtQcdLPRqGihzK12QONS4Sr x56855oL2bIVX6skwkrJ+if5YYvn4pzxEAJ3Wn4EDdD6Rdfb1QwSa+g7Az5S+IVUyHnUCCSo= X-Gm-Gg: AfdE7cn0vKE6zt2HsjXX9uZAQ7dTK+xceonQDMlHPxuBDGTkCqQhxoOphwG+6rYpUwd QTIC+DghKqYD13r7ZDt+2cEoJ9nmNC+LWp7HNX3T78vU++7JmCxqkG8oL5u5lkyy8JelUogQGbc CxvyDM3ZhIQlc38UUqMmJUnbYxG6sHbUiFgT7EPojrHmfykpxfGE4cAOrFQUkuabMPrPCYvBaez lHmSbxK7yGeVLM5Fl0ANExdFI4Bi+7CDPbL/oWRYNJPMsOqrKU7v5NVWKoNtwAI8N2M7juVmVhM +B4BmG8AtL6lBnKa1V6x7KvcImKd4FHdSBn7kR/G45JJlsPqjERc0eikuoS5G/PGbWtd X-Received: by 2002:a05:600d:8445:20b0:493:2805:ae06 with SMTP id 5b1f17b1804b1-493c2b38e31mr1466785e9.2.1782884896653; Tue, 30 Jun 2026 22:48:16 -0700 (PDT) X-Received: by 2002:a05:600d:8445:20b0:493:2805:ae06 with SMTP id 5b1f17b1804b1-493c2b38e31mr1466575e9.2.1782884896276; Tue, 30 Jun 2026 22:48:16 -0700 (PDT) Received: from fedora ([213.175.46.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be81df2asm85299695e9.12.2026.06.30.22.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 22:48:15 -0700 (PDT) From: Ondrej Mosnacek To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Ravi Bangoria , linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] perf test amd ibs: avoid using executable heap Date: Wed, 1 Jul 2026 07:48:07 +0200 Message-ID: <20260701054807.508994-1-omosnace@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Making [parts of] the heap executable is dangerous and is blocked by SELinux on Fedora/RHEL even for an unconfined user. Replace the malloc() + mprotect() combo with just mmap(), creating a private anonymous rwx mapping, which only requires the more commonly allowed "execmem" permission under SELinux (things like JIT or regex compilation need it as well). mmap() with MAP_ANONYMOUS will give us a zeroed mapping that begins on a page boundary, so the result is equivalent to the original code even without a memset() or the page-alignment dance. Verified that the test still passes on a machine with an AMD CPU that has the "ibs" CPU flag. Fixes: 35db59fa8ea2 ("perf test amd ibs: Add sample period unit test") Signed-off-by: Ondrej Mosnacek --- tools/perf/arch/x86/tests/amd-ibs-period.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/tools/perf/arch/x86/tests/amd-ibs-period.c b/tools/perf/arch/x86/tests/amd-ibs-period.c index 6a92b3a23ed7a..b2210b1aa09fb 100644 --- a/tools/perf/arch/x86/tests/amd-ibs-period.c +++ b/tools/perf/arch/x86/tests/amd-ibs-period.c @@ -46,7 +46,6 @@ static int dummy_workload_1(unsigned long count) { int (*func)(void); int ret = 0; - char *p; char insn1[] = { 0xb8, 0x01, 0x00, 0x00, 0x00, /* mov 1,%eax */ 0xc3, /* ret */ @@ -59,18 +58,11 @@ static int dummy_workload_1(unsigned long count) 0xcc, /* int 3 */ }; - p = calloc(2, page_size); - if (!p) { - printf("malloc() failed. %m"); - return 1; - } - - func = (void *)((unsigned long)(p + page_size - 1) & ~(page_size - 1)); - - ret = mprotect(func, page_size, PROT_READ | PROT_WRITE | PROT_EXEC); - if (ret) { - printf("mprotect() failed. %m"); - goto out; + func = mmap(NULL, page_size, PROT_READ | PROT_WRITE | PROT_EXEC, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (!func) { + pr_debug("mmap() failed. %m\n"); + return -1; } if (count < 100000) @@ -93,7 +85,7 @@ static int dummy_workload_1(unsigned long count) } out: - free(p); + munmap(func, page_size); return ret; } -- 2.54.0