From: Leo Yan <leo.yan@arm.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, ilkka@os.amperecomputing.com
Subject: Re: [PATCH 4/5] perf/arm-cmn: Add new filters
Date: Thu, 9 Jul 2026 17:03:10 +0100 [thread overview]
Message-ID: <20260709160310.GG1024232@e132581.arm.com> (raw)
In-Reply-To: <5304caf0300992329742d22b746167b2f3e4174c.1782830759.git.robin.murphy@arm.com>
On Tue, Jun 30, 2026 at 04:19:19PM +0100, Robin Murphy wrote:
[...]
> @@ -284,6 +286,9 @@ enum cmn_filter_select {
> SEL_CBUSY_SNTHROTTLE_SEL,
> SEL_HBT_LBT_SEL,
> SEL_SN_HOME_SEL,
> + SEL_SNP_VC_SEL,
> + SEL_ENHANCED_HBT_LBT_SEL,
> + SEL_EVICT_STATE_SEL,
> SEL_MAX
> };
Though SEL_SNP_VC_SEL/SEL_ENHANCED_HBT_LBT_SEL are not really used in
this patch, I understand this is preparing for new filters.
The secondary filter between SEL_EVICT_STATE_SEL and SEL_HBT_LBT_SEL
also looks good to me:
Reviewed-by: Leo Yan <leo.yan@arm.com>
next prev parent reply other threads:[~2026-07-09 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 15:19 [PATCH 0/5] perf/arm-cmn: Support CMN S3 r2 Robin Murphy
2026-06-30 15:19 ` [PATCH 1/5] perf/arm-cmn: Rename filter variables for clarity Robin Murphy
2026-07-07 5:31 ` Ilkka Koskinen
2026-06-30 15:19 ` [PATCH 2/5] perf/arm-cmn: Refactor event filter programming Robin Murphy
2026-07-07 5:37 ` Ilkka Koskinen
2026-06-30 15:19 ` [PATCH 3/5] perf/arm-cmn: Refactor event filter data Robin Murphy
2026-07-05 15:44 ` Leo Yan
2026-07-06 10:28 ` Robin Murphy
2026-06-30 15:19 ` [PATCH 4/5] perf/arm-cmn: Add new filters Robin Murphy
2026-07-09 16:03 ` Leo Yan [this message]
2026-06-30 15:19 ` [PATCH 5/5] perf/arm-cmn: Support CMN S3 r2 Robin Murphy
2026-07-09 17:09 ` Leo Yan
2026-07-09 19:20 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709160310.GG1024232@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=ilkka@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox