Re: [PATCH v2 02/14] perf c2c: add function view browser skeleton

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing header fallback stub for `perf_c2c__browse_function_view` when `HAVE_SLANG_SUPPORT` is not defined.
--

--- Patch [2]: [PATCH v2 02/14] perf c2c: add function view browser skeleton ---
commit 9be68ac51631d03c2d6030c665e95226db59b140
Author: Jiebin Sun <jiebin.sun@intel.com>

perf c2c: add function view browser skeleton

This commit adds c2c-function.c with a stub entry point and registers it
in the build system. It also declares the function prototype in c2c.h
to lay the groundwork for a future function-level cacheline browser.

> diff --git a/tools/perf/c2c.h b/tools/perf/c2c.h
> index 5c3f6ae633ea8..ffcd43d4c9038 100644
> --- a/tools/perf/c2c.h
> +++ b/tools/perf/c2c.h
> @@ -142,6 +142,7 @@ bool fmt_equal(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b);
>  
>  #ifdef HAVE_SLANG_SUPPORT
>  int perf_c2c__browse_cacheline(struct hist_entry *he);
> +int perf_c2c__browse_function_view(struct hists *hists);
>  #endif

[Severity: Low]
Should there be an #else fallback stub provided for this new function?

When HAVE_SLANG_SUPPORT is not defined, perf_c2c__browse_function_view()
won't be declared. Providing a dummy inline stub that returns an error
like -ENOTSUPP would ensure compilation doesn't break if future code calls
this function unconditionally.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710084247.3576706-1-jiebin.sun@intel.com?part=2