From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDECEAC7 for ; Mon, 13 Jul 2026 18:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783967481; cv=none; b=P08zY2izN2isKc9JUnTyV1O68YpbhtcycBS+ilamitztBiARht5adTW+YLp1DK0hhLke/q8/jxwGtZTQ94N0JeSbFWBJv8GHVb0mgt1+zOTZpOG4mzfp6Dl/og+gX3RlooekxxNkQE0vlm5x1H6guoPsdzllJpBunlqlbXNIB7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783967481; c=relaxed/simple; bh=KI0In3ySDf9mRnX8Es+cnA9ymhX0W8Ck++dZ4+izsFA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=lQ2ucl+cpepizx2oKKaXxBcUbZksgr6oRI7PJpraV9gA5eIQn3FiKmplpcJ0K/KX7L8Vn023VjLsbiidPjEI4X4Fs++9rHV2b/OPxI64x8ZoizXtz5rA79VhJS5Nwce+ynGAcjr98KYPdLZ6c993RzsGcLNfnaQ3zj0z+SwR2jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CKnakGvu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CKnakGvu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3A2B1F00A3A; Mon, 13 Jul 2026 18:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783967479; bh=8SsbfisCNHQ19bt2n0aWC8Xth97Roz5jsmCgKO8oDvw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CKnakGvuygq+NgOUKnAn6VspziN3DReC6DCMuSnG9fD8Kku4asC5jFpBMR8CBip84 rLFbtrl+AW5rZkLbWCtfvNRHeWjSoyu2AEVqU5KEGsU1t3DHVbZVneGJ0vEOlPs1uj bhRgPu/Gz7gaywLM5grOj8r3rzEShzpBxBWYQ9zCWhYQ3snan0UqZ7rzrpjEXOJgjS iIC18gVDEUJxfzC5srmco4KtPLVVl+qCHAlmIJ10Fw+NI6AMilZdoNmTZM1rFb34mq NVZQF/EJBxyI6ySUHj7WDqIdcbKHqr0DEzQCaVBZz3pbyUD6snTQcHY/w5mH64Hbs3 z8+FfM1ZTekqA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 09/12] perf vendor events intel: Add novalake v1.00 events Reply-To: sashiko-reviews@lists.linux.dev To: "Chun-Tse Shao" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20260713181757.481164-10-ctshao@google.com> References: <20260713181757.481164-1-ctshao@google.com> <20260713181757.481164-10-ctshao@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Jul 2026 18:31:19 +0000 Message-Id: <20260713183119.C3A2B1F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The CPUID matching regex for novalake expects a zero-padded mode= l ('0[13]'), but perf generates the CPUID string using '%X' without zero-pa= dding, meaning the events will fail to load. -- --- Patch [9]: [PATCH v1 09/12] perf vendor events intel: Add novalake v1.0= 0 events --- commit 5f5b010b3f6aa216e7d15989744fc8646fec9af1 Author: Chun-Tse Shao perf vendor events intel: Add novalake v1.00 events This commit adds performance monitoring events for the Intel Novalake architecture. It introduces new JSON event definition files and updates the x86 mapfile to associate the new models with these events. > diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-= events/arch/x86/mapfile.csv > index a15cd32809937..d88a22d9de72b 100644 > --- a/tools/perf/pmu-events/arch/x86/mapfile.csv > +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv > @@ -39,6 +39,7 @@ GenuineIntel-6-8[CD],v1.19,tigerlake,core > GenuineIntel-6-2C,v5,westmereep-dp,core > GenuineIntel-6-25,v4,westmereep-sp,core > GenuineIntel-6-2F,v4,westmereex,core > +GenuineIntel-18-0[13],v1.00,novalake,core [Severity: Medium] Will this regex fail to match the actual CPUID string generated by perf? When perf runs on a Novalake processor, get_cpuid_str() formats the CPUID using %s-%u-%X-%X$. For Novalake models 0x01 and 0x03, the %X format specifier does not zero-pad the output. This results in a CPUID string like GenuineIntel-18-1 or GenuineIntel-18-3. Since this regex explicitly expects a leading zero (0[13]), it looks like it won't match the unpadded string, causing the new events to be unavailable. Should this be GenuineIntel-18-[13] instead? [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260713181757.4811= 64-1-ctshao@google.com?part=3D9