From: sashiko-bot@kernel.org
To: "Chun-Tse Shao" <ctshao@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 08/12] perf vendor events intel: Update meteorlake events from 1.21 to 1.22
Date: Tue, 14 Jul 2026 20:56:55 +0000 [thread overview]
Message-ID: <20260714205656.079F21F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714204044.1952031-9-ctshao@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The metric `tma_uc_bound` is referenced as a related metric in multiple `PublicDescription` fields, but it is not defined for the Meteor Lake architecture.
--
--- Patch [8]: [PATCH v2 08/12] perf vendor events intel: Update meteorlake events from 1.21 to 1.22 ---
commit cb395fd3e26bd66c71e3cfa53c9dba3acded6104
Author: Chun-Tse Shao <ctshao@google.com>
perf vendor events intel: Update meteorlake events from 1.21 to 1.22
The updated events were published in:
https://github.com/intel/perfmon/commit/704ef43e4c0738065a0575622cf7d31867b8d48b
> diff --git a/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json b/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
> index 948c16a1f95ba..a23691052237e 100644
> --- a/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
> @@ -797,16 +797,16 @@
> },
> {
> "BriefDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks",
> - "MetricExpr": "100 * (tma_memory_bound * (tma_dram_bound / (tma_dram_bound + tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_store_bound)) * (tma_mem_bandwidth / (tma_mem_bandwidth + tma_mem_latency)) + tma_memory_bound * (tma_l3_bound / (tma_dram_bound + tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_store_bound)) * (tma_sq_full / (tma_contested_accesses + tma_data_sharing + tma_l3_hit_latency + tma_sq_full)) + tma_memory_bound * (tma_l1_bound / (tma_dram_bound + tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_store_bound)) * (tma_fb_full / (tma_dtlb_load + tma_fb_full + tma_l1_latency_dependency + tma_lock_latency + tma_split_loads + tma_store_fwd_blk)))",
> + "MetricExpr": "100 * (tma_memory_bound * (tma_l3_miss_bound / (tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_l3_miss_bound + tma_store_bound)) * (tma_mem_bandwidth / (tma_mem_bandwidth + tma_mem_latency)) + tma_memory_bound * (tma_l3_bound / (tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_l3_miss_bound + tma_store_bound)) * (tma_sq_full / (tma_contested_accesses + tma_data_sharing + tma_l3_hit_latency + tma_sq_full)) + tma_memory_bound * (tma_l1_bound / (tma_l1_bound + tma_l2_bound + tma_l3_bound + tma_l3_miss_bound + tma_store_bound)) * (tma_fb_full / (tma_dtlb_load + tma_fb_full + tma_l1_latency_dependency + tma_lock_latency + tma_split_loads + tma_store_fwd_blk)))",
> "MetricGroup": "BvMB;Mem;MemoryBW;Offcore;tma_issueBW",
> "MetricName": "tma_bottleneck_data_cache_memory_bandwidth",
> "MetricThreshold": "tma_bottleneck_data_cache_memory_bandwidth > 20",
> - "PublicDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks. Related metrics: tma_fb_full, tma_info_system_dram_bw_use, tma_mem_bandwidth, tma_sq_full",
> + "PublicDescription": "Total pipeline cost of external Memory- or Cache-Bandwidth related bottlenecks. Related metrics: tma_fb_full, tma_info_system_dram_bw_use, tma_mem_bandwidth, tma_sq_full, tma_uc_bound",
[Severity: Low]
This isn't a bug, but this adds a reference to tma_uc_bound which doesn't
appear to be defined in the Meteor Lake JSON files. Will this cause a
dangling documentation reference for users looking up the related metrics?
(Note: This same tma_uc_bound reference is also added to the
PublicDescription fields for tma_fb_full, tma_info_system_dram_bw_use,
tma_mem_bandwidth, and tma_sq_full below).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260714204044.1952031-1-ctshao@google.com?part=8
next prev parent reply other threads:[~2026-07-14 20:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 20:40 [PATCH v2 0/12] perf vendor events intel: update Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 01/12] perf vendor events intel: Update alderlake events from 1.39 to 1.40 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 02/12] perf vendor events intel: Update alderlaken " Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 03/12] perf vendor events intel: Update arrowlake events from 1.19 to 1.20 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 04/12] perf vendor events intel: Update clearwaterforest events from 1.02 to 1.04 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 05/12] perf vendor events intel: Update grandridge events from 1.12 to 1.13 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 06/12] perf vendor events intel: Update graniterapids events from 1.19 to 1.20 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 07/12] perf vendor events intel: Update lunarlake events from 1.25 to 1.26 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 08/12] perf vendor events intel: Update meteorlake events from 1.21 to 1.22 Chun-Tse Shao
2026-07-14 20:56 ` sashiko-bot [this message]
2026-07-14 20:40 ` [PATCH v2 09/12] perf vendor events intel: Add novalake v1.00 events Chun-Tse Shao
2026-07-14 23:29 ` Ian Rogers
2026-07-14 20:40 ` [PATCH v2 10/12] perf vendor events intel: Update pantherlake events from 1.06 to 1.07 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 11/12] perf vendor events intel: Update sierraforest events from 1.17 to 1.18 Chun-Tse Shao
2026-07-14 20:40 ` [PATCH v2 12/12] perf vendor events intel: Update emeraldrapids metrics Chun-Tse Shao
2026-07-15 17:35 ` [PATCH v2 0/12] perf vendor events intel: update Chun-Tse Shao
2026-07-15 18:21 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714205656.079F21F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ctshao@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox