Re: [PATCH v8 3/9] selftests: tracing: Add a basic testcase for wprobe

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Error handling blocks checking `$?` are dead code because the test script runs under `set -e`.
--

--- Patch [3]: [PATCH v8 3/9] selftests: tracing: Add a basic testcase for wprobe ---
commit 0ee1282cbf519c56b378956b7875111e8d6bc222
Author: Masami Hiramatsu (Google) <mhiramat@kernel.org>

selftests: tracing: Add a basic testcase for wprobe

This commit adds a basic testcase 'add_remove_wprobe.tc' to verify the adding
and removing operations for wprobe events.

> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_wprobe.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_wprobe.tc
> new file mode 100644
> index 0000000000000..5ddf28ddd2c4b
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_wprobe.tc
> @@ -0,0 +1,69 @@
> +#!/bin/sh

[ ... ]

> +echo "w:my_wprobe w@$TARGET" >> dynamic_events
> +
> +grep -q my_wprobe dynamic_events
> +if [ $? -ne 0 ]; then

[Severity: Low]
Since ftracetest executes these scripts with errexit (set -e) enabled, will
the script exit immediately if the grep command fails?

If the script aborts on the failed command, this if block and the others like
it throughout the script become dead code, preventing the custom diagnostic
messages from being printed in the failure logs.

> +    echo "Failed to create wprobe event"
> +    exit_fail
> +fi
> +
> +test -d events/wprobes/my_wprobe
> +if [ $? -ne 0 ]; then

[Severity: Low]
Similarly here, does the test command cause an immediate exit before $? can be
evaluated?

> +    echo "Failed to create wprobe event directory"
> +    exit_fail
> +fi

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/178417033089.209165.16717079876036408877.stgit@devnote2?part=3