Re: [RFC PATCH v2 02/13] x86/hw_breakpoint: Unify breakpoint install/uninstall

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unnecessary write to debug address registers (DR0-DR3) during breakpoint uninstall causes a performance regression.
--

--- Patch [2]: [RFC PATCH v2 02/13] x86/hw_breakpoint: Unify breakpoint install/uninstall ---
commit 5b286a3cc2eb7cc8f15c628fb198117f5bc1729d
Author: Jinchao Wang <wangjinchao600@gmail.com>

x86/hw_breakpoint: Unify breakpoint install/uninstall

This commit consolidates breakpoint management to reduce code duplication
by unifying the install and uninstall paths into common management functions.
It also includes linux/types.h to fix a missing build dependency.

> --- a/arch/x86/kernel/hw_breakpoint.c
> +++ b/arch/x86/kernel/hw_breakpoint.c

[ ... ]

> +static void setup_hwbp(struct arch_hw_breakpoint *info, int slot, bool enable)
> +{
> +	unsigned long dr7;
> +
> +	set_debugreg(info->address, slot);
> +	__this_cpu_write(cpu_debugreg[slot], info->address);

[Severity: Medium]
Does this code introduce a performance regression by unconditionally writing to
the hardware debug address registers (DR0-DR3) during uninstallation?

Writing to hardware debug registers is an expensive operation that forces
pipeline flushes on bare metal and causes VM-exits in virtualized environments.
Looking at the old arch_uninstall_hw_breakpoint(), the uninstall path used to
only update DR7 and skipped writing the address register.

Now, when a task with a hardware breakpoint is scheduled out, the perf_event
subsystem uninstalls the breakpoint which calls into setup_hwbp() with
enable=false. This forces an unconditional set_debugreg() on the address
register anyway. Could this write be restricted to only happen when the enable
flag is true?

> +
> +	dr7 = this_cpu_read(cpu_dr7);
> +	if (enable)
> +		dr7 |= encode_dr7(slot, info->len, info->type);
> +	else
> +		dr7 &= ~__encode_dr7(slot, info->len, info->type);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717125023.1895892-1-wangjinchao600@gmail.com?part=2