Re: [Patch v10 03/10] tools headers: Sync x86 headers with kernel sources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Header synchronization mismatch: tools/arch/x86/include/asm/msr-index.h introduces macros not present in the core kernel header.
--

--- Patch [3]: [Patch v10 03/10] tools headers: Sync x86 headers with kernel sources ---
commit a80378c4387abdba00fb87b0094f51fec90aa452
Author: Dapeng Mi <dapeng1.mi@linux.intel.com>

tools headers: Sync x86 headers with kernel sources

This commit adds ARCH_PEBS_VECR_xxx macros to the tools version of the x86
msr-index.h header to sync with the main kernel sources.

> diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h
> index eff29645719bc..8cbc4c4997065 100644
> --- a/tools/arch/x86/include/asm/msr-index.h
> +++ b/tools/arch/x86/include/asm/msr-index.h
> @@ -350,6 +350,13 @@
>  #define ARCH_PEBS_LBR_SHIFT		40
>  #define ARCH_PEBS_LBR			(0x3ull << ARCH_PEBS_LBR_SHIFT)
>  #define ARCH_PEBS_VECR_XMM		BIT_ULL(49)
> +#define ARCH_PEBS_VECR_YMMH		BIT_ULL(50)
> +#define ARCH_PEBS_VECR_EGPRS		BIT_ULL(51)
> +#define ARCH_PEBS_VECR_OPMASK		BIT_ULL(53)
> +#define ARCH_PEBS_VECR_ZMMH		BIT_ULL(54)
> +#define ARCH_PEBS_VECR_H16ZMM		BIT_ULL(55)
> +#define ARCH_PEBS_VECR_EXT_SHIFT	49
> +#define ARCH_PEBS_VECR_EXT		(0x7full << ARCH_PEBS_VECR_EXT_SHIFT)

[Severity: Medium]
The commit message states "Sync newly introduced ARCH_PEBS_VECR_xxx macros
from kernel". Are these macros actually present in the main kernel tree?

Looking at the core kernel version of arch/x86/include/asm/msr-index.h, these
definitions do not appear to exist.

If they are missing from the main kernel header, won't this cause a
divergence between the tools header and the core kernel header, resulting
in warnings from tools/perf/check-headers.sh during the perf build?

>  #define ARCH_PEBS_GPR			BIT_ULL(61)
>  #define ARCH_PEBS_AUX			BIT_ULL(62)
>  #define ARCH_PEBS_EN			BIT_ULL(63)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721072707.3787848-1-dapeng1.mi@linux.intel.com?part=3