Re: [PATCH v2 1/5] perf/arm-cmn: Rename filter variables for clarity

[Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>]

On Tue, 28 Jul 2026 16:59:21 +0100
Robin Murphy <robin.murphy@arm.com> wrote:

> CMN has already grown many more event-specific filters than the original
> Occupancy ID, but since they are all independent of each other we've
> just overloaded them onto the same name. Before we add yet more, and
> they begin to overlap, rename all our "occupid" variables to "filter" so
> that things can be a bit clearer and more consistent (but leaving the
> format attribute itself, to avoid UAPI concerns).
Hi Robin, 

Drive by review... I'm a bit confused. 
The print out change isn't a ABI change?  I'd at least mention what changes
around that in the commit message.

Jonathan

> 
> Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> 
> v2: No change
> 
>  drivers/perf/arm-cmn.c | 53 ++++++++++++++++++++++--------------------
>  1 file changed, 28 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 50402bc4a21d..2a8a67da72c3 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
...

> @@ -709,8 +709,8 @@ static ssize_t arm_cmn_event_show(struct device *dev,
>  				  eattr->type, eattr->eventid);
>  
>  	if (eattr->fsel > SEL_NONE)
> -		return sysfs_emit(buf, "type=0x%x,eventid=0x%x,occupid=0x%x\n",
> -				  eattr->type, eattr->eventid, eattr->occupid);
> +		return sysfs_emit(buf, "type=0x%x,eventid=0x%x,filter=0x%x\n",
> +				  eattr->type, eattr->eventid, eattr->filter);

Changing the format of this smells like ABI change to me.

>  
>  	return sysfs_emit(buf, "type=0x%x,eventid=0x%x\n", eattr->type,
>  			  eattr->eventid);