Re: [PATCH V4 6/6] tools/perf: Add perf tool support for processing powerpc HTM AUXTRACE records

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit POSIX standard header inclusions for libc functions and constants (musl compatibility).
--

--- Patch [6]: [PATCH V4 6/6] tools/perf: Add perf tool support for processing powerpc HTM AUXTRACE records ---
commit a4f98fe075ced1d3def8964f0504e272f95ab7a4
Author: Athira Rajeev <atrajeev@linux.ibm.com>

tools/perf: Add perf tool support for processing powerpc HTM AUXTRACE records

This commit introduces support for processing powerpc HTM AUXTRACE records
in the perf tool. It reads CPU configurations to map AUX buffers correctly
and handles writing trace data and memory configuration records to files.

> diff --git a/tools/perf/util/powerpc-htm.c b/tools/perf/util/powerpc-htm.c
> index 0ef7ecd18c6f3..268cba1e81c91 100644
> --- a/tools/perf/util/powerpc-htm.c
> +++ b/tools/perf/util/powerpc-htm.c
> @@ -14,9 +14,14 @@
>  #include "auxtrace.h"
>  #include "color.h"
>  #include "powerpc-htm.h"
> +#include <errno.h>
>  #include "debug.h"
>  #include "sample.h"

[Severity: Low]
Does this file need additional explicit POSIX header inclusions for musl
compatibility?

Functions like open(), write(), close(), calloc(), and snprintf(), as well
as constants like O_CREAT and O_WRONLY, are used later in this file. Without
explicitly including <fcntl.h>, <unistd.h>, <stdio.h>, <stdlib.h>, and
<string.h> at the top, the perf tool might fail to compile against musl libc,
which does not implicitly include headers.

>  
> +#include <linux/unaligned.h>
> +
> +struct perf_session;
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729124400.65009-1-atrajeev@linux.ibm.com?part=6