From: sashiko-bot@kernel.org
To: "Jiebin Sun" <jiebin.sun@intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 v5 1/9] perf c2c: extract shared data structures into c2c.h
Date: Thu, 30 Jul 2026 09:13:00 +0000 [thread overview]
Message-ID: <20260730091300.BB7A91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260730090521.2206375-2-jiebin.sun@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The header `c2c.h` omits the `#else` dummy inline stub for `perf_c2c__browse_cacheline` when `HAVE_SLANG_SUPPORT` is not defined.
--
--- Patch [1]: [PATCH v5 v5 1/9] perf c2c: extract shared data structures into c2c.h ---
commit 36546c8a38f921a241992fc1080e419739637db8
Author: Jiebin Sun <jiebin.sun@intel.com>
perf c2c: extract shared data structures into c2c.h
Move c2c_hists, compute_stats, c2c_hist_entry, perf_c2c, and the shared
column-formatting structures and macros from builtin-c2c.c into a new
shared header c2c.h. This allows the upcoming function view browser
(c2c-function.c) to reuse these types and formatting definitions.
> diff --git a/tools/perf/c2c.h b/tools/perf/c2c.h
> new file mode 100644
> index 0000000000000..ab7adb85d9c06
> --- /dev/null
> +++ b/tools/perf/c2c.h
[ ... ]
> +/*
> + * The TUI browsers are only built with SLANG support. Their sole callers
> + * live inside HAVE_SLANG_SUPPORT-guarded code in builtin-c2c.c (stdio mode
> + * forces use_browser=0), so no #else stub is needed -- matching the rest of
> + * perf's TUI entry points.
> + */
> +#ifdef HAVE_SLANG_SUPPORT
> +int perf_c2c__browse_cacheline(struct hist_entry *he);
> +#endif
[Severity: Low]
Should there be an #else fallback stub provided for
perf_c2c__browse_cacheline() in c2c.h?
Even though the comment states current callers are guarded, the subsystem
guidelines require header files to provide compatible dummy inline stubs
when a feature define like HAVE_SLANG_SUPPORT is absent.
> +
> +#endif /* _PERF_C2C_H_ */
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260730090521.2206375-1-jiebin.sun@intel.com?part=1
next prev parent reply other threads:[~2026-07-30 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 9:05 [PATCH v5 0/9] perf c2c: add a function view Jiebin Sun
2026-07-30 9:05 ` [PATCH v5 v5 1/9] perf c2c: extract shared data structures into c2c.h Jiebin Sun
2026-07-30 9:13 ` sashiko-bot [this message]
2026-07-30 9:05 ` [PATCH v5 v5 2/9] perf c2c: add function view browser skeleton Jiebin Sun
2026-07-30 9:05 ` [PATCH v5 v5 3/9] perf c2c: add column rendering for function view Jiebin Sun
2026-07-30 9:05 ` [PATCH v5 v5 4/9] perf c2c: add HPP list parsing for function view columns Jiebin Sun
2026-07-30 9:05 ` [PATCH v5 v5 5/9] perf c2c: add function view stats merge and memory management Jiebin Sun
2026-07-30 9:05 ` [PATCH v5 v5 6/9] perf c2c: add function view hierarchy entry creation Jiebin Sun
2026-07-30 9:19 ` sashiko-bot
2026-07-30 9:05 ` [PATCH v5 v5 7/9] perf c2c: build and finalize the function view hierarchy Jiebin Sun
2026-07-30 9:05 ` [PATCH v5 v5 8/9] perf c2c: add function view browser UI and cacheline detail Jiebin Sun
2026-07-30 9:30 ` sashiko-bot
2026-07-30 9:05 ` [PATCH v5 v5 9/9] perf c2c: document function view in perf-c2c man page Jiebin Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730091300.BB7A91F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jiebin.sun@intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox