Linux Perf Users
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@kernel.org>,
	x86@kernel.org, Jinchao Wang <wangjinchao600@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ian Rogers <irogers@google.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v11 04/11] tracing: wprobe: Add watchpoint probe event based on hardware breakpoint
Date: Tue, 4 Aug 2026 08:00:35 +0900	[thread overview]
Message-ID: <20260804080035.6b719368c9328bbdd8219867@kernel.org> (raw)
In-Reply-To: <20260803070356.GV49951@noisy.programming.kicks-ass.net>

On Mon, 3 Aug 2026 09:03:56 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Sun, Aug 02, 2026 at 05:19:10PM +0900, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > 
> > Add a new probe event for the hardware breakpoint called wprobe-event.
> > This wprobe allows user to trace (watch) the memory access at the
> > specified memory address.
> 
> s/the memory/the kernel memory/

Indeed.

> 
> > The new syntax is;
> > 
> >  w[:[GROUP/]EVENT] [r|w|rw]@[ADDR|SYM][:SIZE] [FETCH_ARGs]
> > 
> > User also can use $addr to fetch the accessed address and $value to fetch
> > the accessed memory value (shorthand for '+0($addr)'). No other variables
> > are supported.
> 
> This seems limited to kernel addresses only? Should not also userspace
> addresses be supported?

Hmm, for x86, yes, since it causes a trap after executing (all page fault
are handled). But other architecture like arm64 may not be able to support
it because it needs to enable watchpoint after major page fault.
At this step, I would like to limit it just for kernel memory.

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

  reply	other threads:[~2026-08-03 23:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-02  8:18 [PATCH v11 00/11] tracing: wprobe: x86: Add wprobe for watchpoint Masami Hiramatsu (Google)
2026-08-02  8:18 ` [PATCH v11 01/11] x86/hw_breakpoints: Make DR7 updates NMI safe Masami Hiramatsu (Google)
2026-08-03  6:57   ` Peter Zijlstra
2026-08-03 22:55     ` Masami Hiramatsu
2026-08-03 23:07       ` Peter Zijlstra
2026-08-02  8:18 ` [PATCH v11 02/11] x86/hw_breakpoints: Add arch_modify_local_hw_breakpoint_addr() API Masami Hiramatsu (Google)
2026-08-02  8:18 ` [PATCH v11 03/11] HWBP: Add modify_local_hw_breakpoint_addr() API Masami Hiramatsu (Google)
2026-08-02  8:19 ` [PATCH v11 04/11] tracing: wprobe: Add watchpoint probe event based on hardware breakpoint Masami Hiramatsu (Google)
2026-08-03  7:03   ` Peter Zijlstra
2026-08-03 23:00     ` Masami Hiramatsu [this message]
2026-08-03 23:08       ` Peter Zijlstra
2026-08-02  8:19 ` [PATCH v11 05/11] x86: hw_breakpoint: Add a kconfig to clarify when a breakpoint fires Masami Hiramatsu (Google)
2026-08-02  8:19 ` [PATCH v11 06/11] selftests: tracing: Add a basic testcase for wprobe Masami Hiramatsu (Google)
2026-08-02  8:19 ` [PATCH v11 07/11] selftests: tracing: Add syntax " Masami Hiramatsu (Google)
2026-08-02  8:19 ` [PATCH v11 08/11] tracing: wprobe: Add wprobe event trigger Masami Hiramatsu (Google)
2026-08-03  0:52   ` Masami Hiramatsu
2026-08-02  8:20 ` [PATCH v11 09/11] selftests: ftrace: Add wprobe trigger testcase Masami Hiramatsu (Google)
2026-08-02  8:20 ` [PATCH v11 10/11] tracing/wprobe: Support BTF typecast in fetchargs Masami Hiramatsu (Google)
2026-08-02  8:20 ` [PATCH v11 11/11] tracing/wprobe: Support BTF typecast in wprobe trigger command Masami Hiramatsu (Google)
2026-08-03 12:33 ` [PATCH v11 00/11] tracing: wprobe: x86: Add wprobe for watchpoint Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804080035.6b719368c9328bbdd8219867@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=irogers@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=wangjinchao600@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox