Linux Perf Users
 help / color / mirror / Atom feed
From: Jiebin Sun <jiebin.sun@intel.com>
To: namhyung@kernel.org
Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
	adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
	irogers@google.com, james.clark@linaro.org, jolsa@kernel.org,
	mark.rutland@arm.com, dapeng1.mi@linux.intel.com,
	thomas.falcon@intel.com, tianyou.li@intel.com,
	wangyang.guo@intel.com, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jiebin Sun <jiebin.sun@intel.com>
Subject: Re: [PATCH v8 6/9] perf c2c: add function view hierarchy entry creation
Date: Fri, 14 Aug 2026 11:23:06 +0800	[thread overview]
Message-ID: <20260814032306.2055624-3-jiebin.sun@intel.com> (raw)
In-Reply-To: <anxvDnc2Kx-OSQEj@google.com>

Hi Namhyung,

> What if both DSOs are NULL?

If both are NULL, the outer condition is true, but
left_dso != right_dso is false. The function therefore skips the DSO name
comparison and reaches the final _sort__sym_cmp() call, using the symbols
to distinguish the entries instead.

Thanks,
Jiebin

  reply	other threads:[~2026-08-14  3:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  5:26 [PATCH v8 0/9] perf c2c: add a function view Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 1/9] perf c2c: extract shared data structures into util/c2c.h Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 2/9] perf c2c: add function view browser skeleton Jiebin Sun
2026-08-12  8:26   ` Namhyung Kim
2026-08-14  3:23     ` Jiebin Sun
2026-08-14  6:13       ` Namhyung Kim
2026-08-14  6:48         ` Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 3/9] perf c2c: add column rendering for function view Jiebin Sun
2026-08-12  8:43   ` Namhyung Kim
2026-08-14  3:23     ` Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 4/9] perf c2c: add HPP list parsing for function view columns Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 5/9] perf c2c: add function view stats merge and memory management Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 6/9] perf c2c: add function view hierarchy entry creation Jiebin Sun
2026-08-10  5:49   ` sashiko-bot
2026-08-12  1:47     ` Namhyung Kim
2026-08-12 13:01       ` Namhyung Kim
2026-08-12 13:03   ` Namhyung Kim
2026-08-14  3:23     ` Jiebin Sun [this message]
2026-08-10  5:26 ` [PATCH v8 7/9] perf c2c: build and finalize the function view hierarchy Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 8/9] perf c2c: add function view browser UI and cacheline detail Jiebin Sun
2026-08-10  5:26 ` [PATCH v8 9/9] perf c2c: document function view in perf-c2c man page Jiebin Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814032306.2055624-3-jiebin.sun@intel.com \
    --to=jiebin.sun@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=tianyou.li@intel.com \
    --cc=wangyang.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox