Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jiebin Sun" <jiebin.sun@intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v9 6/9] perf c2c: add function view hierarchy entry creation
Date: Mon, 17 Aug 2026 09:49:55 +0000	[thread overview]
Message-ID: <20260817094956.1DEA11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260817094623.3288456-7-jiebin.sun@intel.com>

> Add the entry-creation layer: owned-reference child allocation and
> insertion, and the level-1/2/3 lookup-or-create functions keyed by
> function symbol (level 1 read-side, level 2 writer) and by the source
> cacheline's existing index (level 3).
> 
> Give synthetic children normal entry operations and acquire their thread
> and map-symbol references. This lets the hierarchy teardown use
> hist_entry__delete() for the common fields while the function-view free
> callback handles the private child tree and containing allocation.
> 
> Reuse cacheline_idx to preserve the source entry identity without adding
> function-view-only state. Add c2c_function__find_cacheline() to locate the
> original cacheline entry by the same index.
> 
> These are driven by the hierarchy builder in the next patch and are
> __maybe_unused until then.
> 
> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260817094623.3288456-1-jiebin.sun@intel.com?part=6


  reply	other threads:[~2026-08-17  9:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17  9:46 [PATCH v9 0/9] perf c2c: add a function view Jiebin Sun
2026-08-17  9:46 ` [PATCH v9 1/9] perf c2c: extract shared data structures into util/c2c.h Jiebin Sun
2026-08-17  9:59   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 2/9] perf c2c: add function view model skeleton Jiebin Sun
2026-08-17  9:48   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 3/9] perf c2c: add column rendering for function view Jiebin Sun
2026-08-17  9:49   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 4/9] perf c2c: add HPP list parsing for function view columns Jiebin Sun
2026-08-17  9:50   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 5/9] perf c2c: add function view stats merge and memory management Jiebin Sun
2026-08-17  9:49   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 6/9] perf c2c: add function view hierarchy entry creation Jiebin Sun
2026-08-17  9:49   ` sashiko-bot [this message]
2026-08-17  9:46 ` [PATCH v9 7/9] perf c2c: build and finalize the function view hierarchy Jiebin Sun
2026-08-17  9:54   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 8/9] perf c2c: add function view browser UI and cacheline detail Jiebin Sun
2026-08-17  9:51   ` sashiko-bot
2026-08-17  9:46 ` [PATCH v9 9/9] perf c2c: document function view in perf-c2c man page Jiebin Sun
2026-08-17  9:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817094956.1DEA11F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=jiebin.sun@intel.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox