From: Peter Zijlstra <peterz@infradead.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Huang Shijie <huangsj@hygon.cn>,
mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
zhongyuan@hygon.cn, fangbaoshun@hygon.cn, yingzhiwei@hygon.cn,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, tglx@kernel.org, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
liuqi@hygon.cn, lijing@hygon.cn
Subject: Re: [RFC PATCH] perf/amd/ibs: Report physical address for IBS fetch samples
Date: Tue, 18 Aug 2026 10:00:24 +0200 [thread overview]
Message-ID: <20260818080024.GB1247881@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <9a39e681-3184-4841-9e19-7fc40956e917@amd.com>
On Tue, Aug 18, 2026 at 10:29:08AM +0530, Ravi Bangoria wrote:
> On 17-Aug-26 1:03 PM, Huang Shijie wrote:
> > The IBS Fetch sampling does not report the physical address of the
> > fetched instruction even when PERF_SAMPLE_PHYS_ADDR is requested,
> > while IBS Op sampling does.
> >
> > This patch reports physical address for IBS fetch samples which can be
> > used for profiling the running program.
>
> PERF_SAMPLE_PHYS_ADDR is meant to capture the _data_ physical address, which
> IBS Fetch doesn't provide. So, repurposing semantics of PERF_SAMPLE_PHYS_ADDR
> for IBS Fetch seems reasonable.
>
> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Well, why confuse things?
As you say, PHYS_ADDR is for ADDR, which is the *data* address, and
FETCH is an instruction address, which we find in IP, not DATA.
What would be the purpose of confusing things and making PHYS_ADDR
relate to IP?
next prev parent reply other threads:[~2026-08-18 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 7:33 [RFC PATCH] perf/amd/ibs: Report physical address for IBS fetch samples Huang Shijie
2026-08-17 7:47 ` sashiko-bot
2026-08-18 4:59 ` Ravi Bangoria
2026-08-18 8:00 ` Peter Zijlstra [this message]
2026-08-18 9:04 ` Ravi Bangoria
2026-08-18 9:19 ` Peter Zijlstra
2026-08-18 9:49 ` Ravi Bangoria
2026-08-18 11:04 ` Huang Shijie
2026-08-18 11:30 ` Peter Zijlstra
2026-08-18 11:59 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818080024.GB1247881@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fangbaoshun@hygon.cn \
--cc=hpa@zytor.com \
--cc=huangsj@hygon.cn \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=lijing@hygon.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuqi@hygon.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yingzhiwei@hygon.cn \
--cc=zhongyuan@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox