Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kohei Enju" <kohei@enjuk.jp>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf config: Fix annotate.hide_src_code documentation
Date: Tue, 18 Aug 2026 16:05:06 +0000	[thread overview]
Message-ID: <20260818160507.04DE41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818144149.101248-2-kohei@enjuk.jp>

> annotate.hide_src_code defaults to true since commit e201757f7a0a ("perf
> annotate: Fix source code annotate with objdump"), but the perf config
> documentation still describes the default as false in a few places.
> 
> Update the documented default and the example.
> 
> Signed-off-by: Kohei Enju <kohei@enjuk.jp>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818144149.101248-1-kohei@enjuk.jp?part=1


  reply	other threads:[~2026-08-18 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 14:40 [PATCH v1 0/2] perf annotate: Fix source option behavior and Kohei Enju
2026-08-18 14:40 ` [PATCH v1 1/2] perf config: Fix annotate.hide_src_code documentation Kohei Enju
2026-08-18 16:05   ` sashiko-bot [this message]
2026-08-18 14:40 ` [PATCH v1 2/2] perf annotate: Honor explicit --source option Kohei Enju
2026-08-18 16:10   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818160507.04DE41F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=kohei@enjuk.jp \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox