Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Falcon" <thomas.falcon@intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 4/6] perf tools: Show memory region in perf-c2c subcommand
Date: Fri, 21 Aug 2026 00:30:03 +0000	[thread overview]
Message-ID: <20260821003004.396791F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260821001819.162277-5-thomas.falcon@intel.com>

> From: Dapeng Mi <dapeng1.mi@linux.intel.com>
> 
> Add memory region field to the cacheline list view to help users
> identify the memory region to which the cacheline belongs. The memory
> region field was included with the introduction of support for the
> Off-module Response facility (OMR) [1] in Intel's Diamond Rapids and
> Nova Lake architectures.
> 
> An example of the new perf c2c output including the memory region
> field is shown below:
> 
> Shared Data Cache Line Table     (112 entries, sorted on Total HITMs)
>        --------------- Cacheline --------------      Tot  ------- Load Hitm -------    Total    Total    Total
> Index             Address  Region  Node  PA cnt     Hitm    Total  LclHitm  RmtHitm  records    Loads   Stores
>     0  0xff1b7032a1e8c5c0  N/A        1      47    2.25%       50       44        6     1024     1023        1
> [ ... ]
> Assisted-by: Sashiko:gemini-3.1-pro-preview
> Assisted-by: GitHub-Copilot:claude-opus-4-8
> Reviewed-by: Ian Rogers <irogers@google.com>
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821001819.162277-1-thomas.falcon@intel.com?part=4


  reply	other threads:[~2026-08-21  0:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  0:18 [PATCH v5 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-08-21  0:18 ` [PATCH v5 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-08-21  0:29   ` sashiko-bot
2026-08-21  0:18 ` [PATCH v5 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
2026-08-21  0:27   ` sashiko-bot
2026-08-21  0:18 ` [PATCH v5 3/6] perf header: Support memory ranges Thomas Falcon
2026-08-21  0:28   ` sashiko-bot
2026-08-21  0:18 ` [PATCH v5 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
2026-08-21  0:30   ` sashiko-bot [this message]
2026-08-21  0:18 ` [PATCH v5 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
2026-08-21  0:32   ` sashiko-bot
2026-08-21  0:18 ` [PATCH v5 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-08-21  0:28   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821003004.396791F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox