Re: [PATCH] perf build: Add rust target flag for loongarch cross compile

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing RUST_TARGET_FLAGS alias for loongarch64.
--

--- Patch [1]: [PATCH] perf build: Add rust target flag for loongarch cross compile ---
commit b2d0a9ab160e1b008ff911474976ee4d8ac95e11
Author: lifangxu <lifangxu@kylinos.cn>

perf build: Add rust target flag for loongarch cross compile

This commit adds the loongarch rust target flag to fix perf cross
compilation errors for the architecture.

> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 0ba307e78fe1f..42c0ef2137502 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
[ ... ]
> @@ -1149,6 +1149,8 @@ ifndef NO_RUST
>      RUST_TARGET_FLAGS_s390	:= s390x-unknown-linux-gnu
>      RUST_TARGET_FLAGS_x86	:= x86_64-unknown-linux-gnu
>      RUST_TARGET_FLAGS_x86_64	:= x86_64-unknown-linux-gnu
> +    RUST_TARGET_FLAGS_loongarch := loongarch64-unknown-linux-gnu
> +

[Severity: Low]
Should there also be an alias for loongarch64 defined here?

Since tools/scripts/Makefile.arch accepts ARCH=loongarch64 but this
makefile config evaluates $(ARCH) directly, a build invoked with
ARCH=loongarch64 will evaluate RUST_TARGET_FLAGS_$(ARCH) as
RUST_TARGET_FLAGS_loongarch64.

Will this cause the build to fail with the unknown architecture error
because that specific alias is missing?

>  
>      ifeq ($(RUST_TARGET_FLAGS_$(ARCH)),)
>        $(error Unknown rust cross compilation architecture $(ARCH))

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821032702.4258-1-lifangxu22@gmail.com?part=1