From: sashiko-bot@kernel.org
To: "Jiebin Sun" <jiebin.sun@intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/4] perf tests c2c: Report skip when the workload fails
Date: Fri, 21 Aug 2026 05:52:09 +0000 [thread overview]
Message-ID: <20260821055210.4AB2F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <7d472dc1b51dbdbf68254535d608c4fb24b75274.1787283281.git.jiebin.sun@intel.com>
> The workload path leaves err at 0 and returns, so the test exits 0 and is
> reported as a pass even though nothing was recorded and neither report
> invocation ran. The check_c2c_support() path above it already sets err=2.
>
> Set err=2 there as well so a failing workload is reported as a skip.
>
> Fixes: ac881007c4bf ("perf tests c2c: Add a basic c2c")
> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787283281.git.jiebin.sun@intel.com?part=2
next prev parent reply other threads:[~2026-08-21 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:56 [PATCH 0/4] perf c2c: Add function-view stdio support and coverage Jiebin Sun
2026-08-21 5:56 ` [PATCH 1/4] perf c2c: Fix documented default coalesce fields Jiebin Sun
2026-08-21 5:57 ` sashiko-bot
2026-08-21 5:56 ` [PATCH 2/4] perf tests c2c: Report skip when the workload fails Jiebin Sun
2026-08-21 5:52 ` sashiko-bot [this message]
2026-08-21 5:56 ` [PATCH 3/4] perf c2c: Add stdio support for the function view Jiebin Sun
2026-08-21 5:58 ` sashiko-bot
2026-08-21 5:56 ` [PATCH 4/4] perf tests c2c: Add function view stdio coverage Jiebin Sun
2026-08-21 5:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821055210.4AB2F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jiebin.sun@intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox