Re: [PATCH perf-tools-next v6 3/5] perf trace: Auto-assign kernel symbol beautifier to function pointer fields

[sashiko-bot@kernel.org]

> Tracepoint fields that convey kernel function pointers, callbacks, and
> call sites, such as "function", "func", "fn", "callback", "action",
> "handler", "caller", "caller_ip", "location", "callsite", and
> "call_site" are currently formatted as generic hexadecimal pointers by
> default.
> 
> Enhance syscall_arg_fmt__init_array() to automatically detect non-array
> function pointer fields by type signature (e.g., typedefs ending with
> "_func_t" or "_fn", or C function pointer types containing "(*)") and
> assign SCA_KSYM as their default beautifier.
> 
> Additionally, register common function pointer and callback field names
> within the sorted syscall_arg_fmts__by_name lookup table. To prevent
> misclassifying dynamic string arrays, enums, or standard non-pointer
> integers sharing generic names, guard SCA_KSYM assignment to true pointer
> [ ... ]
>     ❯ sudo tools/perf/perf trace --event workqueue:workqueue_execute_end --max-events 2 --show-cpu
>          0.000 [000] kworker/u32:15/236682 workqueue:workqueue_execute_end(work: 0xffffffffab2f1420, function: toggle_allocation_gate)
>          0.132 [000] kworker/u32:15/236682 workqueue:workqueue_execute_end(work: 0xffff8ac2c1adc010, function: flush_to_ldisc)
> 
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824133122.751733-1-atomlin@atomlin.com?part=3