Re: [PATCH v2 5/8] perf hisi-ptt: Add parsing of supported message types

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit inclusion of <stdbool.h> for musl compatibility.
--

commit db9f8e2182c24e7486861ffcf7818bd57505c649
Author: Sizhe Liu <liusizhe5@huawei.com>

perf hisi-ptt: Add parsing of supported message types

This commit parses PCIe TLP messages into types like MWr, Msg, Atom, IO, CFG,
and CPL based on the Header DW0 Format and Type fields. The parsed message
type is stored in the packet buffer to select correct field layouts for later
processing.

> diff --git a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
> index 00bd9309df68a..e63fe1534693c 100644
> --- a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
> +++ b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
> @@ -79,6 +79,66 @@ static const char * const hisi_ptt_4dw_pkt_field_name[] = {
>  	[HISI_PTT_4DW_HEAD3]	= "Header DW3",
>  };
>  
> +/* TLP message parsers below according to PCIe r6.4 sec 2.2.1.1 & 2.2.1.2 */
> +static bool hisi_ptt_is_mwr_tlp(uint32_t format, uint32_t type)

[Severity: Low]
Does this missing explicit inclusion of <stdbool.h> break compilation under
musl libc? 

The Perf subsystem guidelines require explicit inclusion of POSIX standard
headers for types like bool, because unlike glibc, musl strictly separates
declarations and does not implicitly pull them in.

> +{
> +	return (format == 0x2 || format == 0x3) && (type == 0);
> +}
> +

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827140442.2031128-1-liusizhe5@huawei.com?part=5