From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.18] perf/x86/intel/uncore: Guard against invalid box control address
Date: Mon, 31 Aug 2026 13:51:39 +0000 [thread overview]
Message-ID: <20260831135139.77BAA1F00ADB@smtp.kernel.org> (raw)
In-Reply-To: <20260831133314.4125787-18-sashal@kernel.org>
> From: Zide Chen <zide.chen@intel.com>
>
> [ Upstream commit 3c19ea24f02658c4b8ad364458fae4d77fdb3fae ]
>
> Theoretically, intel_uncore_find_discovery_unit() could return NULL,
> e.g., when a CPU die is offline during uncore enumeration and its PMU
> units are not added to the discovery RB-tree.
>
> Guard against a NULL return value and the resulting invalid box control
> address (0) before accessing hardware.
>
> Signed-off-by: Zide Chen <zide.chen@intel.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Link: https://patch.msgid.link/20260602144908.263680-3-zide.chen@intel.com
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260831133314.4125787-18-sashal@kernel.org?part=1
next prev parent reply other threads:[~2026-08-31 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260831133314.4125787-1-sashal@kernel.org>
2026-08-31 13:20 ` [PATCH AUTOSEL 6.18] perf/x86/intel/uncore: Guard against invalid box control address Sasha Levin
2026-08-31 13:51 ` sashiko-bot [this message]
2026-08-31 13:24 ` [PATCH AUTOSEL 6.18-6.12] perf: Fix addr_filter_ranges lifetime Sasha Levin
2026-08-31 15:04 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831135139.77BAA1F00ADB@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox