Linux Perf Users
 help / color / mirror / Atom feed
From: longlong yan <yanlonglong@kylinos.cn>
To: acme@kernel.org
Cc: namhyung@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com, adrian.hunter@intel.com,
	james.clark@linaro.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	longlong yan <yanlonglong@kylinos.cn>
Subject: [PATCH] perf bench numa: add NULL check after calloc()
Date: Wed,  2 Sep 2026 15:09:13 +0800	[thread overview]
Message-ID: <20260902070913.1424-1-yanlonglong@kylinos.cn> (raw)

Two calloc() calls in the numa benchmark lack NULL return checks,
leading to potential NULL pointer dereferences on allocation failure:

1. worker_process(): the allocated `pthreads` array is used in the
   following for-loop via pthreads[t] without checking for NULL.

2. __bench_numa(): the allocated `pids` array is used in the following
   for-loop via pids[i] without checking for NULL.

Add BUG_ON() checks after each calloc(), consistent with the existing
NULL check style used elsewhere in the same file (e.g., node_present
and nodes allocations).

Signed-off-by: longlong yan <yanlonglong@kylinos.cn>
---
 tools/perf/bench/numa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
index 42d7afc03f9b..371a74e3da1b 100644
--- a/tools/perf/bench/numa.c
+++ b/tools/perf/bench/numa.c
@@ -1419,6 +1419,7 @@ static void worker_process(int process_nr)
 	bind_to_cpumask(td->bind_cpumask);
 
 	pthreads = calloc(g->p.nr_threads, sizeof(pthread_t));
+	BUG_ON(!pthreads);
 	process_data = setup_private_data(g->p.bytes_process);
 
 	if (g->p.show_details >= 3) {
@@ -1625,6 +1626,7 @@ static int __bench_numa(const char *name)
 		return -1;
 
 	pids = calloc(g->p.nr_proc, sizeof(*pids));
+	BUG_ON(!pids);
 	pid = -1;
 
 	if (g->p.serialize_startup) {
-- 
2.43.0


             reply	other threads:[~2026-09-02  7:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  7:09 longlong yan [this message]
2026-09-02  7:15 ` [PATCH] perf bench numa: add NULL check after calloc() sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902070913.1424-1-yanlonglong@kylinos.cn \
    --to=yanlonglong@kylinos.cn \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox