From: sashiko-bot@kernel.org
To: "Nylon Chen" <nylon.chen@sifive.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf bench futex: Define SYS_futex on 32-bit arches with 64-bit time_t
Date: Wed, 02 Sep 2026 09:37:18 +0000 [thread overview]
Message-ID: <20260902093719.B8A531F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902093210.3571958-1-nylon.chen@sifive.com>
> The kernel does not provide sys_futex() on 32-bit architectures that lack
> a 32-bit time representation, such as riscv32. Consequently glibc does not
> define SYS_futex there, only SYS_futex_time64, and perf bench's futex
> benchmarks fail to build:
>
> bench/futex.h: In function 'futex_syscall':
> bench/futex.h:77:18: error: 'SYS_futex' undeclared (first use in this function)
>
> Define SYS_futex as SYS_futex_time64 when only the latter is available.
> The guard and its comment are taken verbatim from
> tools/testing/selftests/futex/include/futextest.h, where they were added by
> commit 04850819c65c ("selftests/futex: Define SYS_futex on 32-bit
> architectures with 64-bit time_t"), keeping the two futex userspace headers
> in sync.
>
> [ ... ]
> which is unavailable on older distributions. This change deliberately
> avoids that dependency and adds only the one guard needed to fix
> compilation.
>
> Signed-off-by: Nylon Chen <nylon.chen@sifive.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902093210.3571958-1-nylon.chen@sifive.com?part=1
next prev parent reply other threads:[~2026-09-02 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 9:32 [PATCH] perf bench futex: Define SYS_futex on 32-bit arches with 64-bit time_t Nylon Chen
2026-09-02 9:37 ` sashiko-bot [this message]
2026-09-03 5:04 ` Ian Rogers
2026-09-08 20:51 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902093719.B8A531F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=nylon.chen@sifive.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox