From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F2FE35F602 for ; Wed, 2 Sep 2026 15:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788364144; cv=none; b=iXFN4fEqaCWRxHJ1djLgUyD2g1yphkyjKUGZWJxQN9a7Icbe3Vj2LQv5O2C5kzhfXScS3rr62GlxOBBBjQaiq266nNOfZFgnhhJ2iRPY95RaiLSKJSs0eZ/vaAUqa9DK+o5SVLOExHCCzcP9H51xNMSOS1iw0HY+uXHbmElC7AQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788364144; c=relaxed/simple; bh=7vAxRRbJLQbGjzYhZfE8GOaSa9he4WmrA/5IM4MQBt4=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=E5g104EMld+EievcO6TlWWnPCLaE6D4I+feUDw8xFceOP+D2xNP1holSlZFWcZvKMnwG7zYJHfJ+wIN1B51JU6LCSoZRHCrJM/21qTuRTiJG6ffc9vG/EUdp0sfnJN/eo2wtFzKylhTmvhpzv/Q775blC6DgXTcrfTuWzUAfIug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=thSvBrCZ; arc=none smtp.client-ip=209.85.216.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="thSvBrCZ" Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3968dfff779so1833194a91.1 for ; Wed, 02 Sep 2026 08:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1788364142; x=1788968942; darn=vger.kernel.org; h=content-type:to:from:subject:message-id:mime-version:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=BjTye98IgOGmelm/cLqooPf13I/e9bRqoz8Zlbwjvx4=; b=thSvBrCZEsx6wbkeNQMEjROAhCJLvWFjtg0zunL0u1MhghHML38tubA5vCI/9aYkaO GRqHZ3Q9hxMetc5X5BmEQ3EKYU3V6cEP17LQZfOJpE8s3VEADUyGI7GQG2tw685HXujO tn6KMmkgWftQQKtfuD/dT/5bY4kbilSsL2vrLxrdgSyEP1lzWC/X/PDyeA8d1tUIaa89 UdD+oBlW78FWstD4fK1tF4Dxz4xuas1IMV5ZkMtjiK616foE5WOl0IwzKcRUnD6vdU3w FNj82clanUCCrfJ8rtQfLz2L3eCs0yH/ERBaLZVjGP1JrtYXSKetSSQkLyZ9Jgshg5n6 S21g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788364142; x=1788968942; h=content-type:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BjTye98IgOGmelm/cLqooPf13I/e9bRqoz8Zlbwjvx4=; b=lmwYIaDsPo2F79yZdBJqtSzWN8mBTZewSJeXGOc6bz/6BKF0anbS3fqgL+O3ccbXfC Ucvf8un2T4wQuaVVrPDs0pCrkB1Ak3r8buuPyDI45n2d5HjQsZg6uo3DBUe31ChVw2GF FginNAAgmb0IAZsnRO1NE6JROxbo0PlavRAh1ntSk6m/xoFQKyK60z4hjwvFoWnOzqmK bzZMP1LW17+cQYviKAqNAQoanPHE7iHkyMJx0PRLTOpxHrk2xh6Ybcg68M8rs+S+rBQL shEys+5S2/xPUSarU2Myj3z0qCi7pDOgvPktIkE91cUVI51XhKZcwNgpuTE1ofnO3/8L qrhA== X-Forwarded-Encrypted: i=1; AKwUvBw2f697v6snJjdkERCsnF5ay0OkMUhcevhImjCrPIK6T5vsPV638IHlQA2BeQK5aQd4hIHekqs4Oyx4wdek8xcd@vger.kernel.org X-Gm-Message-State: AFuF++mtgI9nijT3W0D7xZZNfy9+pJmvN3Y9BTt2/yxHgCVR2ONDLSaJ zNJTVWr7Q0G+ggMBFzazvjL6I336Xx5np3B6g6LGgz8QNzlwSpEzXnqUP2jlFCvk3JB0xUIJFD3 9CUWz8qv0vA== X-Received: from dlag8.prod.google.com ([2002:a05:701b:2508:b0:141:4a59:5b22]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1d44:b0:38f:cab0:9aa9 with SMTP id 98e67ed59e1d1-39b0803b0efmr157324a91.13.1788364142054; Wed, 02 Sep 2026 08:49:02 -0700 (PDT) Date: Wed, 2 Sep 2026 08:48:52 -0700 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.966.g6673acef38-goog Message-ID: <20260902154858.2078885-1-irogers@google.com> Subject: [PATCH v3 0/6] perf tool: Build dependency tidy up From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Tianyou Li , Jiebin Sun , Dapeng Mi , Eric Biggers , Thomas Richter , Stephen Brennan , Swapnil Sapkal , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" In doing some work on bazel building of perf (bazel being stricter on how header files are used), rather than just making the bazel BUILD files more generous in how they accept header file issues like transitive dependencies it felt cleaner to address them. These patches tackle the most severe issues such as cache.h pulling in UI code, hist.h bringing in UI code, unused header files, transitive dependencies, etc. While cleaning up the dependencies in perf.c, change how missing commands are handled to give a more meaningful error message at run time about missing build time dependencies. v1 and v2 were previously sent just addressing the cache.h issue: https://lore.kernel.org/linux-perf-users/20260828222045.1314766-1-irogers@google.com/ Ian Rogers (6): perf tool: Remove util/cache.h perf tool: Tidy up util/cache.h header file users perf tool: Remove unused includes in perf.c perf tool: Move usage strings and functions to perf.c perf tool: Add fallback stubs for missing dependencies perf hist: Remove keysym.h include from hist.h tools/perf/builtin-annotate.c | 57 +++++++++------ tools/perf/builtin-c2c.c | 1 + tools/perf/builtin-config.c | 18 +++-- tools/perf/builtin-help.c | 30 ++++---- tools/perf/builtin-kvm.c | 1 + tools/perf/builtin-report.c | 1 + tools/perf/builtin-top.c | 1 + tools/perf/builtin.h | 3 + tools/perf/perf.c | 114 ++++++++++++++++++----------- tools/perf/ui/browsers/annotate.c | 1 + tools/perf/ui/browsers/hists.c | 1 + tools/perf/ui/browsers/scripts.c | 1 + tools/perf/ui/libslang.h | 2 + tools/perf/util/Build | 1 - tools/perf/util/cache.h | 31 -------- tools/perf/util/config.c | 38 ++++++---- tools/perf/util/help-unknown-cmd.c | 15 +++- tools/perf/util/hist.h | 6 -- tools/perf/util/path.c | 10 +-- tools/perf/util/path.h | 6 +- tools/perf/util/strbuf.c | 14 ++-- tools/perf/util/usage.c | 34 --------- tools/perf/util/util.h | 4 - 23 files changed, 194 insertions(+), 196 deletions(-) delete mode 100644 tools/perf/util/cache.h delete mode 100644 tools/perf/util/usage.c -- 2.55.0.966.g6673acef38-goog