linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf tests: Improvements to build-test performance
Date: Thu, 03 Sep 2026 05:04:54 +0000	[thread overview]
Message-ID: <20260903050455.1FF8C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903045603.3611902-1-irogers@google.com>

> Replace hardcoded 'make' calls with '$(MAKE)' within tests/make to
> ensure GNU Make jobserver file descriptors are properly inherited by
> nested builds.
> 
> Additionally, remove the 'unexport MAKEFLAGS' from
> tools/perf/Makefile. This hack was originally added to prevent the
> wrapper's internal '-j$(JOBS)' override from crashing when parent
> jobserver tokens were present. Instead, use proper GNU Make
> conditionals to check for '-j' or 'jobserver' strings within
> MAKEFLAGS. If a jobserver is already orchestrating the build,
> gracefully back off and let GNU Make manage parallelism natively.
> 
> Finally, optimize the 'out' target (which processes 'run_O'
> out-of-tree builds) by stripping sequential bottlenecks like $(call
> clean) from isolated tmp directories, and wrapping the target list in
> a parallel sub-make call.
> 
> These combined changes enable 'build-test' out-of-tree targets to
> build completely concurrently without severing jobserver tokens.
> 
> Unscientifically measured the change lowered the build-test from
> around 15 minutes to 10 minutes on a 28 threaded Alderlake CPU. Fixing
> the jobserver issues meant the machine remained somewhat usable while
> running the test.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903045603.3611902-1-irogers@google.com?part=1


      reply	other threads:[~2026-09-03  5:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 15:31 [PATCH v1] perf tests: Improvements to build-test performance Ian Rogers
2026-09-02 15:40 ` sashiko-bot
2026-09-03  4:56 ` [PATCH v2] " Ian Rogers
2026-09-03  5:04   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903050455.1FF8C1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).