Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Zafir Rasyidi Taufik" <zafir.taufik@starlabs.sg>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: Fix slab use-after-free in filter_chain
Date: Tue, 08 Sep 2026 02:40:43 +0000	[thread overview]
Message-ID: <20260908024044.4112B1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908023223.1516819-2-zafir.taufik@starlabs.sg>

> Syzbot reported a slab use-after-free read in uprobe_mmap. The root cause is
> when a trace_probe has a sibling event, unregister_trace_uprobe() does
> not unlink &tu->consumer. This memory can still be referenced in
> multiple locations, namely filter_chain and uprobe_mmap, resulting in a
> use-after-free. This is not a security issue as creating uprobes
> requires CAP_SYS_ADMIN.
> 
> Here's a short repro in bash which will trigger a KASAN report, tested on
> v7.2.4. Note the offsets used for /bin/true may need some adjusting,
> they are the offset of its entrypoint in this example:
> ```
> echo "p:uprobe_test/evS /bin/true:0x23d0" >> /sys/kernel/tracing/uprobe_events
> echo "p:uprobe_test/evS /bin/true:0x23d4" >> /sys/kernel/tracing/uprobe_events
> echo 1 > /sys/kernel/tracing/events/uprobe_test/evS/enable
> echo "-:uprobe_test/evS" >> /sys/kernel/tracing/uprobe_events
> /bin/true
> ```
> 
> This is my first time sending a patch to the linux kernel mailing list,
> apologies if there are any mistakes.
> 
> Reported-by: syzbot+1340ad4350ad43394c10@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=1340ad4350ad43394c10
> Signed-off-by: Zafir Rasyidi Taufik <zafir.taufik@starlabs.sg>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908023223.1516819-2-zafir.taufik@starlabs.sg?part=1


      reply	other threads:[~2026-09-08  2:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  2:32 [PATCH] perf: Fix slab use-after-free in filter_chain Zafir Rasyidi Taufik
2026-09-08  2:40 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908024044.4112B1F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zafir.taufik@starlabs.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox