Re: [PATCH v8 1/3] tools: port perf ui from GTK 2 to GTK 4

[sashiko-bot@kernel.org]

> Port straight to GTK 4 rather than GTK 3, since GTK 4 is where new
> development happens and GTK 3 is old itself now.
> 
> GTK 4 drops GtkContainer, GdkScreen, and the gtk_main()/
> gtk_dialog_run() family perf's GTK UI relied on. Containers get
> per-widget setters (gtk_box_append() and friends), monitor geometry
> comes from GdkMonitor instead of GdkScreen, and the main and
> error-dialog loops become explicit GMainLoops quit from the
> "close-request" and "response" signals. Widgets are visible by default
> now, so gtk_widget_show_all()/set_no_show_all() go away, and the
> remaining gtk_widget_show()/gtk_widget_hide() calls become
> gtk_widget_set_visible() (with a small wrapper where "response" needs
> to pass gtk_widget_hide() as a callback, since it no longer exists as
> a plain function).
> 
> [ ... ]
> and the check treats deprecation warnings as errors.
> HAVE_GTK_INFO_BAR_SUPPORT and its statusbar-only fallback go away; the
> info bar is now built unconditionally.
> 
> Signed-off-by: Matt Turner <mattst88@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-perf-gtk2-v8-0-e90d5d155f0d@gmail.com?part=1