From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback
Date: Wed, 09 Sep 2026 18:18:10 +0000 [thread overview]
Message-ID: <20260909181810.C988C1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260909181030.1870496-1-irogers@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added fallback feature test 'libbfd-liberty-z-zstd' is never executed, making the new libbfd zstd fallback condition dead code and failing to fix the link error.
--
commit 5475f00ff10a072611b6ed7d2a3b54cfea18c571
Author: Ian Rogers <irogers@google.com>
tools build: Add explicitly sequenced -lzstd to libbfd feature fallback
This commit extends the build feature testing cascade to probe for -lz -lzstd
when basic libbfd fallback variants fail. This aims to natively support
recent distributions that ship statically compiled binutils with zstd
dependencies.
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
[ ... ]
> @@ -905,6 +905,8 @@ ifdef BUILD_NONDISTRO
> EXTLIBS += -lbfd -lopcodes -liberty
> else ifeq ($(feature-libbfd-liberty-z), 1)
> EXTLIBS += -lbfd -lopcodes -liberty -lz
> + else ifeq ($(feature-libbfd-liberty-z-zstd), 1)
> + EXTLIBS += -lbfd -lopcodes -liberty -lz -lzstd
[Severity: Medium]
Is the feature-libbfd-liberty-z-zstd check actually executed?
It looks like $(call feature_check,libbfd-liberty-z-zstd) is missing from
the BUILD_NONDISTRO feature checks earlier in tools/perf/Makefile.config.
Without the feature check being called to trigger the evaluation, will this
conditional always evaluate to false and act as dead code, leaving the build
still failing on systems requiring the zstd fallback?
> endif
>
> CFLAGS += -DHAVE_LIBBFD_SUPPORT
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909181030.1870496-1-irogers@google.com?part=1
prev parent reply other threads:[~2026-09-09 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 18:10 [PATCH v1] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback Ian Rogers
2026-09-09 18:18 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909181810.C988C1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox