linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/9] perf symbol: Fall back to fetching the vmlinux by build ID
Date: Mon, 14 Sep 2026 13:18:40 +0000	[thread overview]
Message-ID: <20260914131840.EE25A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260914125451.2045-4-acme@kernel.org>

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> A profile recorded on a kernel that is no longer installed, be it
> because the machine was rebooted into a new kernel or because the
> profile is being processed on another machine, can't have its kernel
> symbols resolved: /proc/kallsyms matches the running kernel, not the
> one in the profile, and is refused when restricted, e.g. with
> kernel.perf_event_paranoid > 1, while the build-id cache may carry
> just a kallsyms copy with zeroed addresses.  With no kernel symbols
> the kernel samples can't be annotated, so they all end up in the
> '(unknown)' data type and the kernel is missing from the data type
> profile JSON "dsos" entry.
> 
> As a last resort, when the kernel symbols can't be found locally and
> the user didn't specify a kallsyms file, fetch the vmlinux keyed by
> [ ... ]
> struct tty_struct, struct qspinlock, etc, with the kernel DSO, keyed
> by its build ID, appearing in the data type profile JSON.
> 
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914125451.2045-1-acme@kernel.org?part=3


  reply	other threads:[~2026-09-14 13:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 12:54 [PATCH v5 0/9] perf tools: Annotate fixes, stdio progress indication, debuginfo-client in more places Arnaldo Carvalho de Melo
2026-09-14 12:54 ` [PATCH 1/9] perf test: Skip data_type_profiling when the PMU cannot record memory events Arnaldo Carvalho de Melo
2026-09-14 13:00   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 2/9] perf debuginfo: Fetch debuginfo keyed by build ID using debuginfod Arnaldo Carvalho de Melo
2026-09-14 13:07   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 3/9] perf symbol: Fall back to fetching the vmlinux by build ID Arnaldo Carvalho de Melo
2026-09-14 13:18   ` sashiko-bot [this message]
2026-09-14 12:54 ` [PATCH 4/9] perf annotate-data: Show the sample count in the data-type browser Arnaldo Carvalho de Melo
2026-09-14 13:24   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 5/9] perf report: Add --progress option Arnaldo Carvalho de Melo
2026-09-14 13:37   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 6/9] perf scripts: Add perf-stuck, to tell where a running perf is stuck Arnaldo Carvalho de Melo
2026-09-14 13:44   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 7/9] perf annotate-data: Resolve type DIEs in the debug file they came from Arnaldo Carvalho de Melo
2026-09-14 13:54   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 8/9] perf mem record: Request PERF_SAMPLE_CPU by default Arnaldo Carvalho de Melo
2026-09-14 14:11   ` sashiko-bot
2026-09-14 12:54 ` [PATCH 9/9] perf mem record: Use the IBS swfilt filter when available Arnaldo Carvalho de Melo
2026-09-14 14:15   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914131840.EE25A1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).