Linux Perf Users
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: sashiko-bot@kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v15 09/12] tracing/wprobe: Add set_wprobe and clear_wprobe event triggers
Date: Mon, 14 Sep 2026 15:46:58 +0900	[thread overview]
Message-ID: <20260914154658.a43ec4fc877c9fa873d0550a@kernel.org> (raw)
In-Reply-To: <20260907041036.DA9C41F00A3A@smtp.kernel.org>

On Mon, 07 Sep 2026 04:10:36 +0000
sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] clear_wprobe incorrectly rejects legitimate fields starting with "unlimited"
> --
> 
> commit f87f4797ae7a52cd2de4840afea59fb8bb8bbaf6
> Author: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> tracing/wprobe: Add set_wprobe and clear_wprobe event triggers
> 
> This commit adds the set_wprobe and clear_wprobe event triggers to dynamically
> attach and detach hardware breakpoint address monitoring based on event field
> contents.
> 
> Link: https://lore.kernel.org/all/59637b96946653393a7ad3c7de094094796b39c2.1785067572.git.wangjinchao600@gmail.com/
> 
> > diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
> > --- a/kernel/trace/trace_wprobe.c
> > +++ b/kernel/trace/trace_wprobe.c
> 
> [ ... ]
> 
> > +static int wprobe_trigger_cmd_parse(struct event_command *cmd_ops,
> > +				    struct trace_event_file *file,
> > +				    char *glob, char *cmd,
> > +				    char *param_and_filter)
> > +{
> 
> [ ... ]
> 
> > +	/* clear_wprobe does not need field, but can have optional field. */
> > +	if (!clear) {
> 
> [ ... ]
> 
> > +	} else if (param && (isalpha(param[0]) || param[0] == '_')) {
> > +		if (strncmp(param, "count=", 6) != 0 &&
> > +		    strncmp(param, "unlimited", 9) != 0) {
> [Severity: Medium]
> Will this substring comparison mistakenly intercept legitimate C-identifier
> field names that start with "unlimited"?

Ah, yes. I understand it. Maybe we can use strcmp(param, "unlimited") so that
it will pass the field name that starts with "unlimited".

> 
> If a user passes a legitimate event field name like "unlimited_size" to
> clear_wprobe, the strncmp(param, "unlimited", 9) != 0 check will evaluate
> to false. The parsing logic in wprobe_trigger_cmd_parse() will mistakenly
> assume it is a count parameter, skip the field parsing, and pass the string
> to event_trigger_parse_num().
> 
> Since event_trigger_parse_num() attempts to parse "unlimited_size" using
> kstrtoul(), it will fail and return -EINVAL. Could this prevent users from
> using clear_wprobe on any valid field beginning with "unlimited"?

Thanks,

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

  reply	other threads:[~2026-09-14  6:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  3:46 [PATCH v15 00/12] tracing: wprobe: x86: Add wprobe for watchpoint Masami Hiramatsu (Google)
2026-09-07  3:46 ` [PATCH v15 01/12] x86/mce: Fix hardware debug register corruption on task migration Masami Hiramatsu (Google)
2026-09-07  3:57   ` sashiko-bot
2026-09-07  3:46 ` [PATCH v15 02/12] x86/hw_breakpoints: Make DR7 updates NMI safe Masami Hiramatsu (Google)
2026-09-07  4:00   ` sashiko-bot
2026-09-14  1:02     ` Masami Hiramatsu
2026-09-14  2:49     ` Masami Hiramatsu
2026-09-07  3:46 ` [PATCH v15 03/12] x86/hw_breakpoints: Add arch_modify_local_hw_breakpoint_addr() API Masami Hiramatsu (Google)
2026-09-07  4:02   ` sashiko-bot
2026-09-14  5:13     ` Masami Hiramatsu
2026-09-07  3:47 ` [PATCH v15 04/12] HWBP: Add modify_local_hw_breakpoint_addr() API Masami Hiramatsu (Google)
2026-09-07  4:04   ` sashiko-bot
2026-09-07  3:47 ` [PATCH v15 05/12] tracing/wprobe: Add wprobe (watchpoint probe) trace event support Masami Hiramatsu (Google)
2026-09-07  4:15   ` sashiko-bot
2026-09-14  5:25     ` Masami Hiramatsu
2026-09-07  3:47 ` [PATCH v15 06/12] x86: hw_breakpoint: Add a kconfig to clarify when a breakpoint fires Masami Hiramatsu (Google)
2026-09-07  3:52   ` sashiko-bot
2026-09-07  3:47 ` [PATCH v15 07/12] selftests: tracing: Add a basic testcase for wprobe Masami Hiramatsu (Google)
2026-09-07  3:53   ` sashiko-bot
2026-09-07  3:47 ` [PATCH v15 08/12] selftests: tracing: Add syntax " Masami Hiramatsu (Google)
2026-09-07  3:58   ` sashiko-bot
2026-09-07  3:47 ` [PATCH v15 09/12] tracing/wprobe: Add set_wprobe and clear_wprobe event triggers Masami Hiramatsu (Google)
2026-09-07  4:10   ` sashiko-bot
2026-09-14  6:46     ` Masami Hiramatsu [this message]
2026-09-07  3:48 ` [PATCH v15 10/12] selftests: tracing: Add wprobe trigger testcase Masami Hiramatsu (Google)
2026-09-07  3:58   ` sashiko-bot
2026-09-07  3:48 ` [PATCH v15 11/12] tracing/wprobe: Support BTF typecast in fetchargs Masami Hiramatsu (Google)
2026-09-07  4:03   ` sashiko-bot
2026-09-07  3:48 ` [PATCH v15 12/12] tracing/wprobe: Support BTF struct offset resolution in set_wprobe trigger Masami Hiramatsu (Google)
2026-09-07  4:06   ` sashiko-bot
2026-09-11  7:27 ` [PATCH v15 00/12] tracing: wprobe: x86: Add wprobe for watchpoint Jinchao Wang
2026-09-12 13:36   ` Masami Hiramatsu
2026-09-14  6:16     ` Jinchao Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914154658.a43ec4fc877c9fa873d0550a@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox