Re: [PATCH v9 3/6] perf header: Support memory ranges

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: missing <fcntl.h> for POSIX file operations
--

commit 3d29383e185965a287c0130b763ba9ba19b03791
Author: Thomas Falcon <thomas.falcon@intel.com>

perf header: Support memory ranges

This patch parses memory range data from the ACPI MRRM table exposed via
sysfs and saves it in the header of the perf data file under a new feature
bit. Memory range data can then be viewed with perf-report and perf-script.

Link: https://lore.kernel.org/lkml/20250505173819.419271-1-tony.luck@intel.com/

> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 7db7da090a1e0..83416ce395d7c 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
[ ... ]
> @@ -1892,6 +1893,132 @@ static int write_cpu_domain_info(struct feat_fd *ff,
>  	return ret;
>  }
>  
> +static int memory_range__read(struct memory_range *range, const char *path)
> +{
> +	char buf[32];
> +	ssize_t n;
> +	int dfd, fd, tmp, ret = -1;
> +
> +	dfd = open(path, O_RDONLY | O_DIRECTORY);

[Severity: Low]
Should we explicitly include <fcntl.h> for these POSIX file operations?

The standard strictly requires <fcntl.h> for open(), openat(), and constants
like O_DIRECTORY. Because tools/perf/util/header.c does not explicitly include
it, this can lead to build failures in environments like musl libc that
enforce strict namespace separation.

> +	if (dfd < 0)
> +		return -1;
> +
> +#define _R(name, dst, conv)			\
> +	fd = openat(dfd, name, O_RDONLY);	\
> +	if (fd < 0)				\
> +		goto out;			\
> +	n = read(fd, buf, sizeof(buf) - 1);	\

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914224650.52982-1-thomas.falcon@intel.com?part=3