Re: [PATCH v4 2/9] perf ui hist: Add support for aggregated total_period and merging entries

[sashiko-bot@kernel.org]

> Add the histogram side of hybrid event merging.
> 
> When events are merged the entries of the other events are linked to
> the leader's entries as pairs, and a row is then displayed as the sum
> over an entry and its pairs. Teach the hpp code to work on that sum:
> 
>  - The formatting and sorting routines add up the value of an entry and
>    of each of its pairs, so a row shows, and is sorted by, the total
>    across the core PMUs rather than the leader's value alone.
>  - Percentages are taken against the summed total_period of the merged
>    hists. Computing each event's share against its own PMU's total
>    would leave the column not adding up to 100%.
>    hist_entry__get_percent_limit_merged() does the same for
>    --percent-limit, which would otherwise compare against the wrong
>    total and filter out the wrong entries.
> [ ... ]
> 
> Merging is never combined with --hierarchy, which the merge_entries
> tests rely on.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917050708.704702-1-irogers@google.com?part=2