Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/dwc_pcie: Fix PCI device reference leak in dwc_pcie_pmu_probe()
Date: Thu, 17 Sep 2026 13:42:38 +0000	[thread overview]
Message-ID: <20260917134238.C87DE1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917133241.2153478-1-vulab@iscas.ac.cn>

> dwc_pcie_pmu_probe() gets a reference to the PCI device with
> pci_get_domain_bus_and_slot(), but returns -ENODEV directly when
> dwc_pcie_des_cap() does not find the RAS DES capability, leaking the
> reference.  The other early returns and the success path drop it.
> 
> Release the reference on that path as well.
> 
> Fixes: 7f35b429802a ("perf/dwc_pcie: fix duplicate pci_dev devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917133241.2153478-1-vulab@iscas.ac.cn?part=1


      reply	other threads:[~2026-09-17 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 13:32 [PATCH] perf/dwc_pcie: Fix PCI device reference leak in dwc_pcie_pmu_probe() Wentao Liang
2026-09-17 13:42 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917134238.C87DE1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox