Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 3/5] perf trace-event: Free the global trace_event when a command ends
Date: Fri, 18 Sep 2026 06:41:36 +0000	[thread overview]
Message-ID: <20260918064136.CC8E61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918063249.2172589-4-irogers@google.com>

> The tep handle behind trace_event__tp_format() is a process wide cache
> of the running kernel's tracepoint formats and nothing ever released
> it, as the comment above it had noted since the code was added.
> 
> Add trace_event__exit() and call it from run_builtin() next to the
> existing perf_config__exit(). By then the builtin has returned, so the
> tep_event pointers it handed out, such as the ones cached in
> evsel->tp_format, are no longer reachable.
> 
> Note that this does not silence every libtraceevent report under
> leak sanitizer. Parsing a print fmt drops a token inside the library
> itself, and as those allocations are not linked into the handle,
> freeing the handle cannot reclaim them.
> 
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918063249.2172589-1-irogers@google.com?part=3


  reply	other threads:[~2026-09-18  6:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  6:32 [PATCH v1 0/5] perf trace: Tracepoint format error handling and leak fixes Ian Rogers
2026-09-18  6:32 ` [PATCH v1 1/5] perf trace-event: Report tracepoint format errors with NULL and errno Ian Rogers
2026-09-18  6:41   ` sashiko-bot
2026-09-18  6:32 ` [PATCH v1 2/5] perf trace-event: Reuse an already parsed tracepoint format Ian Rogers
2026-09-18  6:38   ` sashiko-bot
2026-09-18  6:32 ` [PATCH v1 3/5] perf trace-event: Free the global trace_event when a command ends Ian Rogers
2026-09-18  6:41   ` sashiko-bot [this message]
2026-09-18  6:32 ` [PATCH v1 4/5] perf trace: Free the host machine allocation Ian Rogers
2026-09-18  6:45   ` sashiko-bot
2026-09-18  6:32 ` [PATCH v1 5/5] perf thread: Free the comm read from procfs Ian Rogers
2026-09-18  6:38   ` sashiko-bot
2026-09-25 13:00 ` [PATCH v1 0/5] perf trace: Tracepoint format error handling and leak fixes Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918064136.CC8E61F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox