From: sashiko-bot@kernel.org
To: "Salvatore Bonaccorso" <carnil@debian.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: Please backport subset of 2f5d370dec3f ("perf test: Change all remaining #!/bin/sh to #!/bin/bash") for stat_bpf_counters.sh script to v6.12.y and older
Date: Fri, 18 Sep 2026 19:14:21 +0000 [thread overview]
Message-ID: <20260918191421.C87B71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <aq2MQLKmyrxkFd0Y@eldamar.lan>
> Hi
>
> Recently for v5.15.221, v6.1.188, v6.6.157, v6.12.110, v6.18.52 and
> v7.2.6, the commit b02027776ac5 ("perf tests: Fix flakiness in BPF
> counters test on hybrid systems") was backported, but it introduced
> bash specific syntax. For versions after 2f5d370dec3f ("perf test:
> Change all remaining #!/bin/sh to #!/bin/bash") aka before v6.17-rc1
> this is not a problem.
>
> The proposed patch is a stable series backports specific one, as one
> cannot simply backport 2f5d370dec3f ("perf test: Change all remaining
> #!/bin/sh to #!/bin/bash") without picking as well some other context
> related changes to make it possible. So I was proposing to only change
> shebang to #!/bin/bash in stable series were it is a problem, as in
> the stat_bpf_counters.sh script.
> [ ... ]
>
> No upstream commit exists for this change as for versions post 6.17-rc1
> the scripts were converted to #!/bin/bash already.
>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/aq2MQLKmyrxkFd0Y@eldamar.lan?part=1
next prev parent reply other threads:[~2026-09-18 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 19:08 Please backport subset of 2f5d370dec3f ("perf test: Change all remaining #!/bin/sh to #!/bin/bash") for stat_bpf_counters.sh script to v6.12.y and older Salvatore Bonaccorso
2026-09-18 19:14 ` sashiko-bot [this message]
2026-09-18 19:20 ` Salvatore Bonaccorso
2026-09-18 19:41 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918191421.C87B71F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=carnil@debian.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox