Re: [PATCH v3 perf-tools-next 6/7] perf trace beauty: Validate payload size in augmented sockaddr beautifier

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: missing stddef.h inclusion for offsetof() violating musl compatibility
--

commit 319d4746425928b01209fdee80a73a7983207fbb
Author: Aaron Tomlin <atomlin@atomlin.com>

perf trace beauty: Validate payload size in augmented sockaddr beautifier

This commit adds payload size validation to the augmented sockaddr beautifier
in perf trace. It prevents reading memory past the available buffer when
parsing malformed or truncated records.

> diff --git a/tools/perf/trace/beauty/sockaddr.c b/tools/perf/trace/beauty/sockaddr.c
> index a17a27ac2a6ff..98fdabc997812 100644
> --- a/tools/perf/trace/beauty/sockaddr.c
> +++ b/tools/perf/trace/beauty/sockaddr.c
> @@ -39,31 +39,48 @@ static size_t af_local__scnprintf(struct sockaddr *sa, char *bf, size_t size)
>  	return scnprintf(bf, size, ", path: %s", sun->sun_path);
>  }
>  
> -static size_t (*af_scnprintfs[])(struct sockaddr *sa, char *bf, size_t size) = {
> -	[AF_LOCAL] = af_local__scnprintf,
> -	[AF_INET]  = af_inet__scnprintf,
> -	[AF_INET6] = af_inet6__scnprintf,
> +static const struct af_scnprintf {
> +	size_t (*scnprintf)(struct sockaddr *sa, char *bf, size_t size);
> +	size_t min_size;
> +} af_scnprintfs[] = {
> +	[AF_LOCAL] = { af_local__scnprintf, offsetof(struct sockaddr_un, sun_path) + 1 },

[Severity: Low]
Does this code need an explicit inclusion of stddef.h for the offsetof macro?

When compiling perf tools against musl libc, relying on implicit includes can
lead to compilation failures because musl does not include headers implicitly
like glibc does. Should an explicit include for stddef.h be added to maintain
compatibility with musl?

> +	[AF_INET]  = { af_inet__scnprintf,  sizeof(struct sockaddr_in) },
> +	[AF_INET6] = { af_inet6__scnprintf, sizeof(struct sockaddr_in6) },
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919005530.728615-1-atomlin@atomlin.com?part=6