From: sashiko-bot@kernel.org
To: "Alireza Haghdoost" <haghdoost@uber.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 4/4] perf test: Test lazy symbol loading and symbol memory limits
Date: Sun, 20 Sep 2026 02:39:08 +0000 [thread overview]
Message-ID: <20260920023908.8654F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260919-perf-symbol-memory-send-v2-4-495b8f00ad7c@uber.com>
> From: Alireza Haghdoost <haghdoost@uber.com>
>
> Add a perf script shell test for --lazy-load-symbols and
> --max-symbol-bytes.
>
> Record a small callchain fixture, require evidence that the controlled
> perf DSO built an on-demand index, and compare only extracted occurrences
> of the controlled test_loop symbol. This avoids coupling the test to
> addresses, diagnostics, or architecture-specific symbols for which the
> eager and lazy loaders have documented differences.
>
> Derive the constrained lazy budget from the unlimited run's
> index-reservation peak. This gives a deterministic boundary where the
> index fits and later materialization reaches the limit. Also verify eager
> limiting, malformed size rejection, and one-time warning behavior.
>
> Report unsupported recording, missing controlled output, unavailable
> libelf, and unavailable dependent data as skips without replacing a prior
> failure. Keep helper returns safe under set -e. Add focused coverage for
> skip-status preservation and truncated string-table reads in the lazy
> materialization path.
>
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-perf-symbol-memory-send-v2-0-495b8f00ad7c@uber.com?part=4
prev parent reply other threads:[~2026-09-20 2:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 2:33 [PATCH v2 0/4] perf script: Bounded and lazy symbol loading Alireza Haghdoost via B4 Relay
2026-09-20 2:33 ` [PATCH v2 1/4] perf symbols: Fix broken ELF_C_READ_MMAP fallback guard Alireza Haghdoost via B4 Relay
2026-09-20 2:42 ` sashiko-bot
2026-09-20 23:52 ` Namhyung Kim
2026-09-20 2:33 ` [PATCH v2 2/4] perf script: Add --max-symbol-bytes to bound ELF symbol memory Alireza Haghdoost via B4 Relay
2026-09-20 2:43 ` sashiko-bot
2026-09-21 0:03 ` Namhyung Kim
2026-09-21 4:27 ` Alireza Haghdoost
2026-09-20 2:33 ` [PATCH v2 3/4] perf script: Add --lazy-load-symbols for lazy symbol loading Alireza Haghdoost via B4 Relay
2026-09-20 2:45 ` sashiko-bot
2026-09-20 13:49 ` Alireza Haghdoost
2026-09-21 0:19 ` Namhyung Kim
2026-09-21 4:45 ` Alireza Haghdoost
2026-09-20 2:33 ` [PATCH v2 4/4] perf test: Test lazy symbol loading and symbol memory limits Alireza Haghdoost via B4 Relay
2026-09-20 2:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920023908.8654F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=haghdoost@uber.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox