From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC404BB7EA for ; Mon, 21 Sep 2026 15:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790005667; cv=none; b=F9ZgGtsXt1HaoSu6DFAvdTYEy9dE+C+x2Yjx0bueWSFrXrW+rwE4f43NvKfR/aewHdUg5Abo6GTz7ulOgS/9aAUGPS6ozrTRtyjAzJQ+59FSs/BRG4bSbW1aBlVupPl1+/IZtZV2nb90sX6bLeJ/LErPlEcMUGAY+UOTR0tE+ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790005667; c=relaxed/simple; bh=jB9AaIzaqDofWjWx66kbqSGxxZ1cTXYImVWKUZSMTKM=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=NAJfYKBGfYApY7gmVSQz0ImgRFxtbb+JW58jpJNaO3k6wSqI3gIm47QE+BsRFGMqn07ztMSTITEzdsSIaMgLoAeVBif1CTu8tzW8VfCyaegjjMdsmyn5gYaPY07RItcgTg6Kj91Z7fId29FtfgqdDduvmWKHQKoorGmCsQFWRrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nhoDyNVY; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nhoDyNVY" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e7bcb94d3so21919535e9.2 for ; Mon, 21 Sep 2026 08:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1790005663; x=1790610463; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=P2uYJixWWI2wiwMrAZcn5JhkRyy9zmMz6np7e8ozCa4=; b=nhoDyNVY1zss9FDrnYIJSdB3z8TJDulqN9GLk7O8+uZSEO2TT5vK4wGNEmxrU/a0pj fKWkosJkn6aPWoPpTni2pZFZGpOfy1nW35q2CuqvuzKrU11fOzTnc8s28jsFFaqnZEiN Pzq/076uIldXZH6Mq0GojLh4rbhWHGA3q3nBuMjLM6AbaNc3aOFQ9/rNIBAswgUU+DqU LiW20vXMs+VGRHkDRJ2vuBE5UVos0ORBTXXDd3U0hpWM0VWdQD9XIpHectkkX/EWm1wA UsyViKIeYAPNOz3BdA4LNFmIrjN3MBYs3dEeqBLoVYerhqH8WhF2Yc2Pt07Vt4boDxF8 GbTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790005663; x=1790610463; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=P2uYJixWWI2wiwMrAZcn5JhkRyy9zmMz6np7e8ozCa4=; b=O0CszhSTDcXY2M2if6+OeLdSykzp3cS9DwQTABNKO7pNvi3QR7jWgsAPSUyahGV1V7 fhZYfdmqPPuU2YzHUYv6/0840c6764/baq8rnQLwfGRILuUgaMXnnEQfm1p8zPViXTeS HR5MoTbv7FCOeQVb94QvqGgVaxVQhUfdiago6wVaUIPZlzbAGjn2HzxGtUYjYIoVHj0T yDUpcFKJJt7lfCPY2WSNPq6ctN1EfEDzVJ9E2BbNSWupfWzgI0ViXtJmCVWXhViEusQj 8TXKDYHluziPcN7hA8dqKg28mBDBLXY2zVaz5vr3TezXBzMWsJk6O1sJZxMektuJpGAl cfTw== X-Gm-Message-State: AFuF++n8QIVQ6EqotfoWqf1vfJSESHcn8lPKvKQ1ISsINd6l4Is5za6v xJyJdwhv8cqW/9Uz1CVYsZo/NSnoqFKynmCcAdaLyG27LBb6/IKG+151WR4toWoqN6E= X-Gm-Gg: AYBFou1nxXI1xW1e6uriTKqqIHr6/w3zW9NDb0X+Pq0MryNyMbJCiAZ28uJles2EXiq yYNUNVRg311g3MHGTr0m6RubMc5rYCoSEQiPM+3T5W7Q3pxf+gbCPreEgo88vTbZy/NblVT3nZr 0Gq5/r6ACKV2nJ56Q2FIYzPYzUW6/7WOPcZi/jDPKP8QeDbQAmHwdHAFOI/iolEQQcQZchXp5Gr rer1MUuGVscX6EE0YF3d8TpJIf7/I7vVBxlOoDhegao6C8P3/l492uBqmqcaOtuhDfOZkKlQv6g G0nwjutUD1/lUjn/akul01OmSHROgXmUL56sBrOkqC9C8VQjg/6XgW+ptvUBknXi/O7M6IkTSMr OQWjt460y5gTAZ9ZmxH8+vDIN16AObz5VKcgb1mSyGfQcgEasCV2+E0goHFhIRrTlyN35jWSDxJ ahJdwijGddtNaXhD8yBNTaXiGPGUEZLfDl2J25nML7cdp/ezjOQC3gGnGQCdJxivZfAS7ZdJRhe Ck= X-Received: by 2002:a05:600c:c44c:10b0:49f:ce72:e931 with SMTP id 5b1f17b1804b1-49fce72e987mr68826625e9.35.1790005662923; Mon, 21 Sep 2026 08:47:42 -0700 (PDT) Received: from pop-os.local ([37.18.141.193]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fcd103325sm279287355e9.9.2026.09.21.08.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 08:47:42 -0700 (PDT) From: James Clark Subject: [PATCH 0/2] perf test: Improve shellcheck source directives Date: Mon, 21 Sep 2026 16:47:27 +0100 Message-Id: <20260921-james-perf-shellcheck-source-v1-0-adcfc107c997@linaro.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAI9RsWoC/yXMQQ6CMBAF0KuQWTsJbYgBr2Jc4PSPLSKQjhgTw t2tunybt5EhJxidqo0yXsnSPBW4Q0US++kGTqGYfO2PdecdD/0DxguyskWMo0TInW1es4C1aYO 2nZPQKJViydD0/vXny9+2XgfI83vSvn8AvReCqYAAAAA= X-Change-ID: 20260921-james-perf-shellcheck-source-f48df891cd4f To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.15.2 I was hacking away when I got blocked by a shellcheck warning about an unassigned variable, despite that variable being assigned in a sourced file and having visibly correct source= directive. Confusingly two things turned out to be relevant to this. One is that -a doesn't make shellcheck follow "external" paths, which these are treated as. You need -x for that. Secondly, the source= directives don't cause it to follow the path either, they just suppress a warning message about dynamic paths in versions of shellcheck before 0.7.2. This warning can be silenced with "source=/dev/null" and doesn't require any particular path to be provided if -x isn't used. Signed-off-by: James Clark --- James Clark (2): perf test: Remove redundant shellcheck source paths perf build: Follow sourced files when running shellcheck tools/perf/Makefile.perf | 2 +- tools/perf/tests/shell/annotate.sh | 1 - tools/perf/tests/shell/base_probe/test_adding_kernel.sh | 1 - tools/perf/tests/shell/diff.sh | 1 - tools/perf/tests/shell/inject_aslr.sh | 1 - tools/perf/tests/shell/jitdump-python.sh | 1 - tools/perf/tests/shell/list.sh | 1 - tools/perf/tests/shell/pipe_test.sh | 1 - tools/perf/tests/shell/probe_vfs_getname.sh | 2 -- tools/perf/tests/shell/python-use.sh | 1 - tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 -- tools/perf/tests/shell/record+script_probe_vfs_getname.sh | 2 -- tools/perf/tests/shell/record.sh | 2 -- tools/perf/tests/shell/record_weak_term.sh | 1 - tools/perf/tests/shell/script_dlfilter.sh | 1 - tools/perf/tests/shell/stat+csv_output.sh | 1 - tools/perf/tests/shell/stat+json_output.sh | 1 - tools/perf/tests/shell/stat+std_output.sh | 1 - tools/perf/tests/shell/stat_metrics_values.sh | 1 - tools/perf/tests/shell/test_arm_callgraph_fp.sh | 1 - tools/perf/tests/shell/test_brstack.sh | 1 - tools/perf/tests/shell/test_data_symbol.sh | 1 - tools/perf/tests/shell/test_intel_pt.sh | 1 - tools/perf/tests/shell/test_perf_data_converter_json.sh | 1 - tools/perf/tests/shell/test_test_junit_output.sh | 1 - tools/perf/tests/shell/test_uprobe_from_different_cu.sh | 1 - tools/perf/tests/shell/trace+probe_vfs_getname.sh | 1 - tools/perf/tests/shell/trace_btf_enum.sh | 1 - tools/perf/tests/shell/trace_btf_general.sh | 1 - tools/perf/tests/shell/trace_exit_race.sh | 1 - tools/perf/tests/shell/trace_record_replay.sh | 2 -- tools/perf/tests/shell/trace_summary.sh | 1 - 32 files changed, 1 insertion(+), 37 deletions(-) --- base-commit: 9453bc6a69ef43755f1c28d5688cacdd69fa16bd change-id: 20260921-james-perf-shellcheck-source-f48df891cd4f Best regards, -- James Clark