From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B124E338939 for ; Mon, 21 Sep 2026 05:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789969479; cv=none; b=KeGDM6cw1dox0qEiQy0493JEjixjnM8NLbygXgFEVYBKmBxWL5TaGHTtjcdILkq8lljc/PNLlFMlfLrE0csB69QqOOahj5a7OmNJznX5ztqSA/IAXhtlToIOqQDFzD1yzSqTZpujl2+XpWdqSf3bW69nMIcipUtP1BHBDAUTGYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789969479; c=relaxed/simple; bh=5JN9BwieCXRIUJ2WNg8XwLCSCmBxVrnINLg6yD6HkNY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=KUNqV5NgSBp+QjlEkvazIDwIXcwtmiFClGnx9CCxux2ZFImWiDtwYEKv9t7mEptXWgLgv99HHNQ3WW+62Zg3a6Gh3Z2Y+AXjopK8rRLbb/V+6CHFRNU36xoBSApD4+sl0Gxx/JojZTq71iS1U3m1wLzbRJPbpIUWTm8PNYBoA/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k8I0H25d; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k8I0H25d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3784C1F000FF; Mon, 21 Sep 2026 05:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789969478; bh=6gwPqR5+NPseugsGeClYkg1JrThabhCQ671GNAUPO+I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=k8I0H25dikhCiPR8CRrw4W0g+F0l/vJmhQp8xOlBx0hlqbe/buWwGnE16ZkM9eKPP wy+nswGMxQ9CDlx94m0K6vvwH6yQZA3/Olql7XQmeS/HDTNnaJNabiPGUkPorOqQ4G 8APMq2qE2lCthXMLRIBnstpiKJAav51w1NWkaKyjXomX5gEq65HGgLqEZB5hOYanju kTQee1OAQvySNj1HuxgcoavUtfJBDDFINlh06hlQRuq3GgpV/qfrxjhYf6i44hpUaD Gvi1e5lkOlucEXmeAfUAw4r/Mbas8WqBSujAi64vVT7yV+RYrGem1tCqAAN4uSigsn 7iLzEtHgFQfOA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 37/49] perf python: Port check-perf-trace to perf module Reply-To: sashiko-reviews@lists.linux.dev To: "Ian Rogers" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <2059ccc03e236ce960894d24a266460392819909.1789966896.git.irogers@google.com> References: <2059ccc03e236ce960894d24a266460392819909.1789966896.git.irogers@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Sep 2026 05:44:37 +0000 Message-Id: <20260921054438.3784C1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Port check-perf-trace.py to a standalone script in tools/perf/python/ > using the perf module directly. >=20 > Improvements compared to the legacy script: > - Access tracepoint fields directly as attributes on perf.sample_event > instead of per-event dictionaries and legacy Perf-Trace-Util helpers. > - Decode symbolic flag and enum masks for irq:softirq_entry and > kmem:kmalloc directly in Python and add -i/--input CLI support via > argparse. > - Add full type annotations and clean up Python 2 idioms. >=20 > Add a shell test (test_check_perf_trace_python.sh) to verify the > standalone script. >=20 > Assisted-by: Antigravity:gemini-3.1-pro > Signed-off-by: Ian Rogers Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1789966896.gi= t.irogers@google.com?part=3D37